Conversation
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
| requires-python = ">=3.12" | ||
| dependencies = [ | ||
| "matplotlib>=3.5", | ||
| "networkx>=2.6", |
There was a problem hiding this comment.
Shouldn't these be added as optional dependencies?
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
Very cool but is pgm-io the right place for this? Shouldn't this be part of pgm-ds?
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
|
There was a problem hiding this comment.
Commenting here because otherwise my previous comment may get lost in the work and this PR is not a draft PR:
Is pgm-io the right place for this? Isn't pgm-ds better suited for this?
| [dependency-groups] | ||
|
|
||
| visualization = [ | ||
| "matplotlib>=3.5", |
There was a problem hiding this comment.
Is there a reason you went for Matplotlib instead of the grid drawing tool @nitbharambe introduced for generating the grid images in the docs? That's already a PGM docs dependency anyways
|
Closing this PR as per the offline discussion. It can be re-opened once relevant again. |
3 participants
Functionality to print a PGM network data to a PDF file with electrical diagrams.