Some cleanup and new functionality#83
Some cleanup and new functionality#83ThatRickGuy wants to merge 2 commits intoPostlagerkarte:masterfrom
Conversation
…rag limits from the 2 zones demos.
|
Hey @ThatRickGuy , I like the idea with making the gap between items more flexible. Question is does it make sense to have a GapBetweenItems instead of the NoGapBetweenItems property and allow assigning values? If value = 0 ( same as NoGapBetweenItems) it will automatically apply the negative margin otherwise it would apply the value. This would also mean that there is no need for plk-dd-spacing and plk-dd-no-spacing , because the relevant values would be applied directly. What are your thoughts on this? |
|
Not a bad idea. I had set it as a negative boolean to avoid altering the default behavior and created the CSS class so that folks could alter it as they saw fit. Setting it to an int would be easy enough, but how would you recommend injecting it? Inline style? |
|
Inline style seems to be reasonable. The spacing divs would still get assigned the "plk-dd-spacing" so if people really want the modify the inline style the could do so via !important. |
Did a little clean up and added the NoGapBetweenItems parm. Since the spacer div is used to detect drag locations, it can't just be set to 0px height. This change adds a new div to behave the same but with a negative margin so that it doesn't consume space under the item.