Sync pgxntool to 2.3.0 - #31
Conversation
a6d3287 Release 2.3.0 (#89) 1a7ee20 CLAUDE.md: fix pre-existing documentation-accuracy errors (#88) 35fd187 Fix DATA wildcard skipping historical full-install version scripts (#48) (#80) f9ce2a2 Fix installcheck running before install; make test now fails on regressions (#83) 3ceb930 Rename PGTLE_VERSION to PGXNTOOL_PGTLE_VERSION (#85) 2de8429 claude-code-review.yml: add missing --comment flag (#84) 957bdf6 Restrict @claude mention trigger to a trusted account (#82) b67064b Release 2.2.0 (#77) d949d6d Fix stale README/CLAUDE.md docs; rename internal-only test shim (#76) 6d7822c ci: grant actions:write so bun cache save succeeds (#75) 2738f59 README.asc: fix stale docs, document undocumented API surface (#74) d1d3bee Add make pgxntool-version to print the embedded pgxntool version (#73) 493a0f8 Fix parallel-build SQL corruption, remote hardcoding, and add safety checks (#61) 3b0e3de Fix make pgtle PGTLE_VERSION=X being silently ignored (#66) 21b35ef ci: skip paired-test-PR requirement for doc-only PRs (#71) 55efd03 Rename EXTENSION_VERSION_FILES to EXTENSION__CURRENT_VERSION__FILES (#69) 9d0a856 Fix pgtle.sh rejecting non-numeric version aliases like 'stable' (#57) (#63) 9c2f75f Docs: versioned SQL file tracking tradeoffs and update-testing pattern (#60) c38cf2a ci: never check out fork PR head in claude-code-review pull_request_target job (#70) aab8f2b pgtle_versions.md: fix wrong uninstall_extension() version claim (#59) e2c9174 README.asc: make tag creates a git tag, not a branch (#58) eb84bc6 Stamp 2.1.0 9fbe6f4 Fix results ordering, control file whitespace, ENABLE_* override, debug levels (Postgres-Extensions#31) 88bb4f2 Add Claude Code GitHub Actions workflows (#41) af5bbbb ci: pass repo owners to run-tests.yml for fork-account matching (#40) c7928af Fix repo-root guard to work inside a git worktree (#39) b062fca ci: point reusable test workflow at @master b6cdbfd Add CI workflows and multi-session PR guard (Postgres-Extensions#33) 1ba0987 Stamp 2.0.3 1931cbe Fix pgxntool-sync remote and make it runnable without make (#37) 8176304 Stamp 2.0.2 3e142ab Fix parse_control_file: remove comments before stripping quotes (Postgres-Extensions#27) cacc301 Stamp 2.0.1 bf1db6b Fix bash 3.2 / Linux compatibility issues (Postgres-Extensions#26) 62d0fcb Fix broken ifeq for --load-language=plpgsql on PG < 13 (Postgres-Extensions#24) 121f0b3 Stamp 2.0.0 ad3ca7e Remove .source support; add test/install, test/build, and verify-results (Postgres-Extensions#18) c010cf8 Fix bash 3.2 compatibility (Postgres-Extensions#23) abeb9d3 Remove .source file support from pg_regress integration (Postgres-Extensions#22) 08c1879 Stamp 1.1.2 6e0dad2 Fix double --dbname bug that defeated unique test database names 639756c Stamp 1.1.1 6ba3176 Fix pg_tle exception handler and empty upgrade files (Postgres-Extensions#15) 3b8cb2a Stamp 1.1.0 550a901 Remove commit.md (maintained in pgxntool-test) d73ca93 Add unique test database names to prevent conflicts (Postgres-Extensions#13) 9b344be Add update-setup-files.sh for 3-way merging after pgxntool-sync (Postgres-Extensions#12) ab7f6e2 Stamp 1.0.0 3a571ba Add pg_tle support and modernize test infrastructure (Postgres-Extensions#11) b96ea6d Add support for Claude code; build and doc improvements (Postgres-Extensions#9) e9c24de Fix pg_regress on versions > 12 (Postgres-Extensions#5) REVERT: bed3604 Fix pg_regress on versions > 12 (Postgres-Extensions#5) (Postgres-Extensions#6) git-subtree-dir: pgxntool git-subtree-split: a6d3287e879c45aa0c9a32c6f9513312396c8915
…release # Conflicts: # pgxntool/CLAUDE.md # pgxntool/HISTORY.asc # pgxntool/README.asc # pgxntool/README.html # pgxntool/base.mk
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #32 -- recreated as an upstream-branch PR so it can be part of a formal GitHub stack ( |
Summary
git subtree pullpgxntool fromhttps://github.com/Postgres-Extensions/pgxntool.gitreleasetag, updating the embedded copy from 2.2.0 to 2.3.0. Conflicts resolved by taking upstream's version for every file underpgxntool/(it's vendored, no local patches to preserve) -- same convention as Sync pgxntool to 2.2.0 #21.pgxntool/update-setup-files.shto reconcile setup-copied files against the new version: prunedpgxntool/.claude/andpgxntool/.github/(pgxntool's own dev-only tooling, not meant to be embedded in consumer projects). No other setup files (.gitignore,test/deps.sql) needed changes this time.gh stack linkseparately). Pushed directly to this repo (not just the fork) so the next branch in the stack can reference it as a base without a fork-to-fork PR, same pattern already used foradvanced-testing/foundation.Why this matters for this repo specifically
Two real bugs are fixed in 2.3.0 that are directly relevant to work stacked on top of this branch:
installcheck: installdependency edge inbase.mk. This is the same root cause independently found and filed asPostgres-Extensions/pgxntool-test#62--check-stale-expected: installcheck's early edge could resolveinstallcheckbeforeinstallever ran on a genuinely fresh system. Confirmed present:grep -n "installcheck: install" pgxntool/base.mk-> line 326.DATAwildcard,sql/*--*--*.sql->sql/*--*.sql): fixes historical single-version install files silently dropping out ofmake install'sDATAlist once they're no longer the current version. Doesn't bite test_factory today (only one version, 0.5.0, has ever shipped), but would silently breakTEST_LOAD_SOURCE=updatetesting (added byadvanced-testing/foundation, stacked above this branch) the instant a second version ships --make installwould quietly stop installing the old version's SQL file, and an update test would have nothing toCREATE EXTENSION VERSION 'old'from. Worth calling out explicitly since it's not obvious from the pgxntool changelog alone that this repo has any exposure to it yet.Verification
makebuilds cleanly.make testpasses (3/3) on PG17, from a machine where the extension had never been installed before.make verify-resultspasses cleanly.make pgxntool-versionreports2.3.0.Test plan
makemake teston a machine with no prior installmake verify-results