Skip to content

Guard vendoring template's lint.mk include against tarball builds - #5

Open
jnasbyupgrade wants to merge 1 commit into
mainfrom
guard-lint-mk-tarball-builds
Open

Guard vendoring template's lint.mk include against tarball builds#5
jnasbyupgrade wants to merge 1 commit into
mainfrom
guard-lint-mk-tarball-builds

Conversation

@jnasbyupgrade

Copy link
Copy Markdown
Contributor

Summary

  • The "Consuming this repo" README template's lint.mk include was unconditional, so a git archive tarball build (no .git, no submodule content — what make dist/PGXN release archives use) would abort the whole Makefile parse trying to auto-init .vendor/linter, breaking make/make install entirely.
  • Wraps the template's auto-init rule and include in ifneq ($(wildcard .git),), matching the fix applied downstream in cat_tools PR #80.
  • This repo's README is the reference example other Postgres-Extensions repos copy, so the guard belongs here at the source rather than only being fixed per-consumer.

Test plan

  • Confirm normal checkouts (.git present) still get make lint working as before.

cat_tools PR #80 (Postgres-Extensions/cat_tools) hit this: a git-archive
tarball (what `make dist`/PGXN release archives use) has no .git and no
submodule content, so the unconditional include tried to auto-init
.vendor/linter and aborted the whole Makefile parse -- breaking `make`
and `make install`, not just `make lint`. Wrap the template in
ifneq ($(wildcard .git),) so consumers copying this README's example
don't hit the same bug.
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ad8cf19b-a51f-44c3-8093-2728e2851e95

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant