-
Notifications
You must be signed in to change notification settings - Fork 24
fix(wizard): Fix wizard workbench runs against local MCP/repo #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1d25cc7
chore: add logs
sortafreel ae021a1
chore: logs
sortafreel 33c8e5c
fix: safer stringify
sortafreel 9b3f1b3
chore: more logs on the auth
sortafreel 2a597ca
chore: Simplify comments.
sortafreel 56a7d42
chore: Logs.
sortafreel 350fa16
fix: Ensure check MCP status properly (both locally and in prod).
sortafreel 6f1c211
fix: if require is unavailable - use replacement
sortafreel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ import { Box, Text } from 'ink'; | |
| import { Component, type ReactNode } from 'react'; | ||
| import type { WizardStore } from '@ui/tui/store'; | ||
| import { OutroKind, RunPhase } from '@lib/wizard-session'; | ||
| import { logToFile } from '@utils/debug'; | ||
|
|
||
| interface Props { | ||
| store: WizardStore; | ||
|
|
@@ -29,6 +30,8 @@ export class ScreenErrorBoundary extends Component<Props, State> { | |
| componentDidCatch(error: Error): void { | ||
| const { store } = this.props; | ||
|
|
||
| // The console.error below is wiped with the alt screen; this survives. | ||
| logToFile('[screen-error-boundary]', error); | ||
| // eslint-disable-next-line no-console | ||
| console.error('[ScreenErrorBoundary]', error.message, error.stack); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate? Maybe we should add error tracking to PostHog, too (or instead of the console log) |
||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will say to carefully consider what we log to the log file vs. just capture as a error using error tracking. Some of this shouldn't really be seen by an end user. There's nothing they can do with that info, and we can always get more info in error tracking, anyway.
(I think this is one example)