ci: install Expo deps in-app for Expo react-native jobs#1976
Draft
gewenyu99 wants to merge 2 commits into
Draft
Conversation
Expo apps fail in CI because the GitHub-hosted runners don't ship the Expo environment. Mirror the swift -> macos-latest routing and send react-native/expo apps to a self-hosted runner labeled `expo`. Generated-By: PostHog Code Task-Id: 625c99d1-c95d-4741-a75c-88a1e64f4462
…unner Each matrix entry runs on its own fresh runner, and the Expo apps live outside the pnpm workspace, so their dependencies (including the local Expo CLI the wizard shells out to) are never installed. Rather than route to a dedicated runner, add a conditional `npm ci` step gated to react-native/expo jobs so the Expo environment is present on the standard ubuntu runner. Reverts the earlier runs-on routing. Generated-By: PostHog Code Task-Id: 625c99d1-c95d-4741-a75c-88a1e64f4462
gewenyu99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a conditional step to the
wizard-cimatrix job that installs the Expo app's own dependencies (npm ci) — but only forreact-native/expojobs. This brings in the local Expo CLI the wizard shells out to, so the Expo environment is available on the standardubuntu-latestrunner. No special/self-hosted runner needed.The condition
contains(matrix.app, 'react-native/expo')matches theexpo-react-native-hacker-newsapp and leaves the barereact-native-saasapp (and everything else) untouched.Why
The
expo-react-native-hacker-newsjob was failing in CI because Expo wasn't installed. Root cause: each matrix entry runs on its own fresh runner, and the Expo apps live outside the root pnpm workspace (emptypnpm-workspace.yaml, noworkspacesfield), sopnpm install --frozen-lockfilenever installs the Expo app's deps — including its localexpopackage. Installing them in-app for just those jobs fixes it without provisioning a dedicated runner.Created with PostHog Code from a Slack thread