feat(browser): Surveys can be removed via tree shaking#3088
Closed
dustinbyrne wants to merge 8 commits intomainfrom
Closed
feat(browser): Surveys can be removed via tree shaking#3088dustinbyrne wants to merge 8 commits intomainfrom
dustinbyrne wants to merge 8 commits intomainfrom
Conversation
This is a starting point for permitting the bundle to be tree shaken. this change should effectively be a no-op, with the default extensions replacing the entirety of what was previously available.
No prepackaged extensions. This bundle is not currently exported. It's useful in its current state in showing what the maximum byte size return is when tree shaking.
Why not
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Contributor
Contributor
|
Size Change: -30 kB (-0.47%) Total Size: 6.4 MB
ℹ️ View Unchanged
|
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Contributor
Author
|
Merged via #3165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Surveys is always included in the bundle, whether or not it is used.
Changes
work in progress
Currently 24.8% smaller overall, compared to 18.75% savings on the base branch
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file