Add cache proxy origin backpressure#792
Open
bill-ph wants to merge 1 commit into
Open
Conversation
b2f3a59 to
35cb55d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ORIGIN_MAX_IN_FLIGHT(default0, disabled until configured from production metrics)503 Service UnavailablewithRetry-After: 1if a queued request is canceled before origin fetch startscache_proxy_origin_fetches_queuedandcache_proxy_origin_fetch_queue_wait_seconds{outcome}just test-cache-proxyrecipe and CI jobNotes
cache_proxy_origin_fetches_in_flightremains active origin fills onlyORIGIN_MAX_IN_FLIGHTvalue only after observing production origin-fill, retry, and queue metricsValidation
TestNewCacheProxyOriginBackpressureDefaultsDisabledfailed while the default was still64go test -v ./cmd/cache-proxy -run 'TestNewCacheProxyOriginBackpressureDefaultsDisabled|TestHandleProxyOriginBackpressure|TestNonNegativeIntEnvOrDefault'just test-cache-proxygo test -race ./cmd/cache-proxy -run 'TestHandleProxyOriginBackpressure|TestNonNegativeIntEnvOrDefault' -count=20just lintjust test-unit