fix(controlplane): clarify duckling provisioning readiness#788
Open
EDsCODE wants to merge 5 commits into
Open
Conversation
028cb4a to
349a261
Compare
349a261 to
10ce049
Compare
10ce049 to
b5fe961
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnsureDeletedso the controller requests deletion and waits for Kubernetes finalizers without encoding delete semantics locallyk8s_client_test.goand centralize composed resourceRef lookupTest plan
go test -tags kubernetes ./controlplane/...go test -tags kubernetes ./controlplane/provisionerjust lintskipped at requester direction; localgolangci-lintwas not installed in this environmentAgent context
Implemented from code review feedback and follow-up direction on Duckling naming, provisioning readiness, deletion boundaries, and test organization. I re-audited the hyphen-related diff after moving bucket-name compaction to PostHog/charts#12206: Duckgres now preserves org-derived resource names and only validates the provisioned org ID shape so charts can safely render compact S3 bucket names. No private operational identifiers are included.