Skip to content

fix(controlplane): clarify duckling provisioning readiness#788

Open
EDsCODE wants to merge 5 commits into
mainfrom
eric/duckling-dehyphenate-resource-names
Open

fix(controlplane): clarify duckling provisioning readiness#788
EDsCODE wants to merge 5 commits into
mainfrom
eric/duckling-dehyphenate-resource-names

Conversation

@EDsCODE

@EDsCODE EDsCODE commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep Duckling CR, Lakekeeper CR/Secret/SA, warehouse, and OAuth client names derived from the org ID without bucket-specific compaction
  • remove the stale dehyphenated Duckling lookup path so Kubernetes resource names stay injective and predictable
  • require provisioning org IDs to be canonical lowercase hyphenated UUIDs; this gives the charts-owned S3 bucket compaction a safe input shape without pushing bucket constraints into Duckgres names
  • split generic Duckling status parsing from provisioning readiness checks that inspect composed S3 Bucket readiness explicitly
  • expose EnsureDeleted so the controller requests deletion and waits for Kubernetes finalizers without encoding delete semantics locally
  • move Duckling client Kubernetes fixture coverage into k8s_client_test.go and centralize composed resourceRef lookup

Test plan

  • go test -tags kubernetes ./controlplane/...
  • go test -tags kubernetes ./controlplane/provisioner
  • just lint skipped at requester direction; local golangci-lint was not installed in this environment

Agent context

Implemented from code review feedback and follow-up direction on Duckling naming, provisioning readiness, deletion boundaries, and test organization. I re-audited the hyphen-related diff after moving bucket-name compaction to PostHog/charts#12206: Duckgres now preserves org-derived resource names and only validates the provisioned org ID shape so charts can safely render compact S3 bucket names. No private operational identifiers are included.

@EDsCODE EDsCODE marked this pull request as ready for review June 16, 2026 22:16
@EDsCODE EDsCODE force-pushed the eric/duckling-dehyphenate-resource-names branch from 028cb4a to 349a261 Compare June 16, 2026 22:35
@EDsCODE EDsCODE changed the title fix(controlplane): dehyphenate duckling resource names fix(controlplane): clarify duckling provisioning readiness Jun 16, 2026
@EDsCODE EDsCODE force-pushed the eric/duckling-dehyphenate-resource-names branch from 349a261 to 10ce049 Compare June 16, 2026 23:02
@EDsCODE EDsCODE force-pushed the eric/duckling-dehyphenate-resource-names branch from 10ce049 to b5fe961 Compare June 16, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant