Skip to content

Add cache proxy origin metrics#787

Merged
bill-ph merged 1 commit into
mainfrom
codex/proxy-backpressure-metrics
Jun 17, 2026
Merged

Add cache proxy origin metrics#787
bill-ph merged 1 commit into
mainfrom
codex/proxy-backpressure-metrics

Conversation

@bill-ph

@bill-ph bill-ph commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add Prometheus metrics for cacheable origin fetch outcomes, retry reasons, and active in-flight origin fills
  • keep request behavior unchanged; this PR does not add local admission control, throttling, or backpressure
  • add regression coverage that concurrent distinct origin misses are not locally rejected

Compatibility

Follow-up

  • add the new origin fetch outcome/retry/in-flight metrics to grafana-dashboards/managed-warehouse/duckgres-cache-proxy.json
  • bounded proxy backpressure/queueing remains a separate TODO/PR
  • investigate singleflight leader-cancel behavior for same-key origin fills; today the shared fill uses the first request context, so a leader disconnect can affect other waiters

Validation

  • go test -v ./cmd/cache-proxy
  • focused metric/concurrency tests with -count=50
  • focused metric/concurrency tests with -race -count=20
  • just test-unit
  • just lint

@bill-ph bill-ph force-pushed the codex/proxy-backpressure-metrics branch from 67ce548 to 684fc79 Compare June 16, 2026 20:31
@bill-ph bill-ph changed the title Add cache proxy origin backpressure metrics Add cache proxy origin metrics Jun 16, 2026
@bill-ph bill-ph force-pushed the codex/proxy-backpressure-metrics branch from 684fc79 to e6f1032 Compare June 17, 2026 16:18
@bill-ph bill-ph marked this pull request as ready for review June 17, 2026 16:20
@bill-ph bill-ph force-pushed the codex/proxy-backpressure-metrics branch from e6f1032 to 5814bff Compare June 17, 2026 16:32
@bill-ph bill-ph force-pushed the codex/proxy-backpressure-metrics branch from 5814bff to 787d580 Compare June 17, 2026 17:08
@bill-ph bill-ph merged commit d78d574 into main Jun 17, 2026
25 checks passed
@bill-ph bill-ph deleted the codex/proxy-backpressure-metrics branch June 17, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant