fix(skills): list creating-product-tours in wizard skill list - #286
Draft
posthog[bot] wants to merge 1 commit into
Draft
fix(skills): list creating-product-tours in wizard skill list#286posthog[bot] wants to merge 1 commit into
wizard skill list#286posthog[bot] wants to merge 1 commit into
Conversation
The skill had no `cli:` block, and `generateCliEntries()` only emits skills that declare one. `wizard skill list` prints nothing but `cliEntries`, so the skill has been invisible since it landed — runnable only by typing its exact id, which is how support has had to hand it out. Declare `cli: role: skill` so it lands in `cliEntries` on the next release. No wizard change needed. The contributor docs said a missing block "defaults to the `skill` role" and was still discoverable, which is what made the omission look correct. Corrected in CONTRIBUTING.md, AGENTS.md, and the two doc comments that repeated it. Generated-By: PostHog Code Task-Id: 58dc91a3-6df0-41a5-b8be-b6f9711a980e
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
creating-product-toursnever shows up inwizard skill list. Itsconfig.yamlhas no
cli:block, andgenerateCliEntries()inscripts/lib/build-phases.jsfilters on
allSkills.filter(s => s.cli)— so it never reachescliEntriesinskill-menu.json, which is the only thingwizard skill listprints. The skillruns fine if you already know the id; it just can't be found.
Why
Product tours is sunsetting, and
npx @posthog/wizard@latest skill creating-product-toursis now the recommended path for people who want to build tours themselves. Support
has been handing out the exact id because the listing doesn't have it — two tickets
in the last eight days, one from a customer migrating off a paid guides vendor.
Wizard telemetry shows no traffic reaching the skill at all.
Changes
context/skills/creating-product-tours/config.yaml: declarecli: role: skill.It picks up an entry at build time and
skill listshows it on the next release,with no wizard change needed.
CONTRIBUTING.mdclaimed skills with no
cli:block "default to theskillrole" and were"discoverable via
wizard skill list" — they aren't; they get no entry at all.Same wording corrected in
AGENTS.mdand the two doc comments that repeated it.What I checked while in here
Every other skill missing a
cli:block is deliberately unlisted: sub-skills aflow pulls in (
posthog-best-practices, theintegration-v2steps), skillsfronted by a wizard-native command (
data-warehouse-source,web-analytics,self-driving), or internal test fixtures (quack).creating-product-tourswas the only standalone, user-facing one silently absent, so this is a one-line
fix rather than a sweep.
Not covered here: the support macro still uses the deprecated
--skill <name>flag instead of the
wizard skill <name>positional — that lives outside thisrepo and needs a separate update.
Verification
pnpm test(138 passing) and a fullpnpm build, confirming the entry lands indist/skills/skill-menu.json:{ "skillId": "creating-product-tours", "role": "skill", "displayName": "Creating product tours" }Rendered as
wizard skill listwould print it:Created with PostHog Desktop from this inbox report.