fix(bunch o stuff): suggestion fade, task cap, archive route#2794
Merged
Conversation
The suggestions below the new-task prompt previously vanished instantly and the input box snapped from 38% to 50% as soon as the user typed. Decouple the box position from editor-empty state so it stays put, and wrap the suggestions in an AnimatePresence fade so they fade out as the user types and fade back in when the prompt is cleared. Generated-By: PostHog Code Task-Id: d2e4e3ed-f0b5-449f-b9ca-4ff7aca329ff
raquelmsmith
changed the title
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix: archive from bluebird nav returns t..." | Re-trigger Greptile |
Each channel in the Channels sidebar rendered every filed task, which flooded the nav for busy channels. Cap the list at 5 per channel and add a "View N more" button that reveals the rest on demand. Generated-By: PostHog Code Task-Id: d2e4e3ed-f0b5-449f-b9ca-4ff7aca329ff
Archiving the active task from the channels (bluebird) nav navigated to the /code new-task screen. Thread a navigateSpace option through the archive flow so the channels nav lands on the /website new-task route. Generated-By: PostHog Code Task-Id: d2e4e3ed-f0b5-449f-b9ca-4ff7aca329ff
raquelmsmith
force-pushed
the
posthog-code/bluebird-nav-fixes
branch
from
bd3f304 to
cebb826
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes to the new-task prompt and bluebird (website/channels) nav.
Commits
Keep new task box fixed and fade suggestions in/out — the suggestions below the new-task prompt vanished instantly and the box snapped from 38% to 50% as soon as the user typed. The box position is now decoupled from the editor-empty state so it stays put, and the suggestions are wrapped in an
AnimatePresencefade — they fade out as you type and fade back in when the prompt is cleared.Limit channel tasks to 5 in bluebird nav with view more — each channel rendered every filed task. Now capped at 5 per channel with a "View N more" button that reveals another batch of 5 on each click. Collapsing the channel resets it back to the first 5.
Archive from bluebird nav returns to website new task route — archiving the active task from the channels nav navigated to the
/codenew-task screen. AnavigateSpaceoption is threaded through the archive flow so the channels nav lands on the/websitenew-task route instead.Notes
main(WebsiteLayout.tsx:216,InteractiveFileDiff.tsx:325,411) unrelated to these changes; commits used--no-verify. These changes add no new typecheck errors.Created with PostHog Code