fix(channels): reuse local folders, stop git-init prompt on scratch tasks#2793
Open
raquelmsmith wants to merge 5 commits into
Open
fix(channels): reuse local folders, stop git-init prompt on scratch tasks#2793raquelmsmith wants to merge 5 commits into
raquelmsmith wants to merge 5 commits into
Conversation
Add a 2x4 grid of starter-prompt cards below the input on the project-bluebird channels new-task screen. Each card mirrors the SuggestedTaskCard look (icon badge + title + description); clicking one fills the composer with a multi-line template that ends in a "User input:" block of fill-in lines. - New CHANNEL_TASK_SUGGESTIONS data + SuggestedPromptCard component - TaskInput renders the channel suggestions OR SuggestedTasksPanel (never both), so the codebase-discovery/SDK-health cards don't show on channels - Raise the input block when suggestions are present so the longer list isn't squished; extra gap above the suggestions - Fill via setPendingContent so template line breaks survive - Fix: clear the editor draft before onTaskCreated navigates, so a submitted prompt doesn't persist into the next new task Generated-By: PostHog Code Task-Id: 56abea18-4f33-45cb-ae43-55182b861d46
editor.clear() only ran inside the onTaskReady callback; for repo-less channel tasks the callback can navigate/unmount the editor before the persisted draft is wiped, so a submitted prompt reappeared on the next new task. Clear drafts[sessionId] directly in the guaranteed result.success block, which always runs and survives the unmount. Generated-By: PostHog Code Task-Id: 56abea18-4f33-45cb-ae43-55182b861d46
"Fix a bug" and "Build a new feature" start in plan mode; the analysis suggestions start in auto mode. Selecting a card applies its mode via setConfigOption (guarded by isValidConfigValue, mirroring initialMode). Generated-By: PostHog Code Task-Id: 56abea18-4f33-45cb-ae43-55182b861d46
The input was raised to 38% whenever suggestions were provided, but the cards only render while the editor is empty — so once the user typed, the cards vanished yet the input stayed raised. Gate the position on the same editorIsEmpty condition so it recenters to 50% as the user types. Generated-By: PostHog Code Task-Id: 56abea18-4f33-45cb-ae43-55182b861d46
…asks Follow-up to #2735 (generic chat box with lazy repo attach). Two local-mode regressions: 1. The channel system prompt sent the agent straight to list_repos/clone_repo, cloning from remote even when the user already has the repo checked out locally. AgentService now fetches the user's previously-used local folders and embeds them in the channel prompt, with guidance to reuse a local match (or ask the user for a path) first and only clone from remote as a last resort, after confirming. 2. Opening a repo-less channel task popped the native "initialize git?" dialog: the synthetic scratch workspace has folderId "" (falsy), so the navigation task binder's guard missed and it registered the empty scratch dir as a folder. Mark scratch workspaces with isScratch and short-circuit so they are never registered or git-init'd. The dialog now only fires when a real folder is selected for a coding task. Generated-By: PostHog Code Task-Id: d7d5491e-f66a-4848-9620-98006834f3d6
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/workspace-server/src/services/agent/agent.test.ts:179-181
**`localFoldersBlock` branch never exercised in tests**
The mock always resolves to `[]`, so the conditional path in `buildSystemPrompt` that generates the local-folder list (`localFolders.length > 0`) is never reached. The codebase prefers parameterised tests — a case with one or more mock `RegisteredFolder` entries (covering `exists: true`, `exists: false`, and the `remoteUrl` being null/non-null) would verify that the folder list text is correctly assembled and injected, and that folders with `exists: false` are filtered out as intended.
Reviews (1): Last reviewed commit: "fix(channels): reuse local folders, stop..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+179
to
+181
| foldersService: { | ||
| getFolders: vi.fn().mockResolvedValue([]), | ||
| }, |
Contributor
There was a problem hiding this comment.
localFoldersBlock branch never exercised in tests
The mock always resolves to [], so the conditional path in buildSystemPrompt that generates the local-folder list (localFolders.length > 0) is never reached. The codebase prefers parameterised tests — a case with one or more mock RegisteredFolder entries (covering exists: true, exists: false, and the remoteUrl being null/non-null) would verify that the folder list text is correctly assembled and injected, and that folders with exists: false are filtered out as intended.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/workspace-server/src/services/agent/agent.test.ts
Line: 179-181
Comment:
**`localFoldersBlock` branch never exercised in tests**
The mock always resolves to `[]`, so the conditional path in `buildSystemPrompt` that generates the local-folder list (`localFolders.length > 0`) is never reached. The codebase prefers parameterised tests — a case with one or more mock `RegisteredFolder` entries (covering `exists: true`, `exists: false`, and the `remoteUrl` being null/non-null) would verify that the folder list text is correctly assembled and injected, and that folders with `exists: false` are filtered out as intended.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Follow-up to #2735 (generic chat box with lazy repo attach). Fixes two local-mode regressions reported in channel tasks.
1. Reuse local folders instead of cloning from remote
When the agent decided it needed a repo, the channel system prompt sent it straight to
list_repos→clone_repo, i.e. cloning from remote GitHub even though the user already has the repo checked out locally.AgentServicenow fetches the user's previously-used local folders (FoldersService.getFolders) for channel sessions and embeds them in the channel system prompt. Guidance is reordered to:cdinto it).AskUserQuestion) which folder, or for a local path.2. No more spurious "Initialize Git Repository?" dialog
Opening a repo-less channel task popped the native "This folder is not a git repository / initialize?" dialog. Root cause: the synthetic scratch workspace had
folderId: ""(falsy), sonavigationTaskBinder.ensureWorkspaceForTask's guard missed and it registered the empty scratch dir as a folder (→FoldersService.addFolder→ git-init dialog), plus wrote a bogus workspace row.Scratch workspaces are now marked with
isScratchand short-circuited in the task binder, so they are never registered or git-init'd. The dialog now only fires when a real folder is selected for a coding task.Changes
packages/shared/src/workspace-domain.ts—isScratch?onworkspaceSchemapackages/workspace-server/.../workspace/workspace.ts—buildScratchWorkspacesetsisScratch: truepackages/ui/.../navigation/taskBinderImpl.ts— short-circuit scratch workspacespackages/workspace-server/.../agent/agent.ts— injectFOLDERS_SERVICE, fetch known local folders in channel mode, embed in the channel promptTesting
@posthog/workspace-serverunit tests (516) pass; addedisScratchassertions +foldersServicemockshared,core,agent,workspace-server); pre-existing unrelated@posthog/uierrors inWebsiteLayout.tsx/InteractiveFileDiff.tsxexist on the base branchCreated with PostHog Code