fix(canvas): keep bluebird Home nav in the Channels space#2791
Merged
Conversation
The project-bluebird left nav's Home item called navigateToHome, routing to /code/home and leaving the Channels space — switching the whole view back to the Code app. Point it at the existing /website/home mirror (navigateToWebsiteHome) instead, so it renders the same shared HomeView while keeping the channels chrome. One source of truth: both /code/home and /website/home render HomeView. Generated-By: PostHog Code Task-Id: b3de37db-b354-417e-8d5e-5daf6a22d6c7
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(canvas): keep bluebird Home nav in t..." | Re-trigger Greptile |
The bluebird/Channels sidebar rendered its own Home SidebarItem unconditionally, unlike the Code pane's SidebarNavSection which gates HomeItem behind HOME_TAB_FLAG. Put the Channels Home button behind the same flag so the two navs stay consistent. Generated-By: PostHog Code Task-Id: 9aa4efe5-2287-4f06-9bd7-b591469d3437
Contributor
|
Reviews (2): Last reviewed commit: "feat: gate Channels Home nav button behi..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clicking Home in the project-bluebird (Channels) left nav navigated to
/code/home, which leaves the Channels space and swaps the whole view back to the Code app. This points the Home item at the existing/website/homemirror route so it renders the same sharedHomeViewwhile keeping the channels chrome.How
The supporting infrastructure already existed:
routes/website/home.tsx—/website/homeroute rendering the sameHomeViewas/code/home(single source of truth).useAppViewmaps both/code/homeand/website/hometotype: "home", so active-state highlighting works.__root.tsxkeeps the channels chrome (isChannelsSpace) for any/website/*path.navigateToWebsiteHome()already exists innavigationBridge.ts.The only missing wiring was the sidebar click. This PR:
onClickfromnavigateToHome(/code/home) →navigateToWebsiteHome(/website/home) inChannelsSidebar.tsx.Result
One
HomeViewcomponent, rendered under both/code/homeand/website/home. Clicking Home in the bluebird sidebar now stays within the Channels view instead of switching the whole app.🤖 Generated with Claude Code