Make inbox sidebar badge follow active filters

[andrewm4894]

Problem

When a user filters the inbox by a specific source (e.g. Scouts), priority, or search, the inbox count badge on the left sidebar did not update — it kept showing the total pull-request count across all sources. That left the sidebar badge contradicting the count shown next to the Pull requests tab inside the inbox, which is confusing.

Changes

The sidebar called useInboxAllReports({ ignoreFilters: true }), which hard-pinned the source/priority/search filters to empty. Dropping ignoreFilters makes the badge track the same filtered count the Pull requests tab shows, so the two always agree. Reviewer scope (For you / Entire project) already followed the user's choice and is unchanged.

How did you test this?

• pnpm --filter @posthog/ui typecheck — no type errors in the changed files (remaining errors are pre-existing unbuilt-dependency module-resolution issues unrelated to this change).
• Verified no existing tests assert the old sidebar-badge behavior.

Automatic notifications

• Publish to changelog?
• Alert Sales and Marketing teams?

---

Created with PostHog Code from a Slack thread

[github-actions]

React Doctor found no issues in the changed files. 🎉

_{Reviewed by React Doctor for commit c4d8c36.}

[greptile-apps]

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/ui/src/features/sidebar/components/SidebarNavSection.tsx:89
**Superfluous store subscriptions after removing `ignoreFilters`**

Without `ignoreFilters: true`, the hook now subscribes to `searchQuery`, `sortField`, and `sortDirection` from the filter store, but neither of these affects `counts.pulls` (the only field the sidebar uses). `pullRequestCountQuery` — the source of `counts.pulls` — only uses `source_product`, `priority`, and `suggested_reviewers`. The result is that every search keystroke and every sort-order change re-renders `SidebarNavSection` and re-runs the `scopedReports` memo (including `filterReportsBySearch`), without the badge value ever changing. It won't cause a visible bug but is extra work on a component that's always mounted. Consider adding a `pullRequestsOnly` path (or a narrower `ignoreSearchAndSort` flag) to prevent these subscriptions for the sidebar context.

_{Reviews (1): Last reviewed commit: "Make inbox sidebar badge follow active f..." | Re-trigger Greptile}

[greptile-apps]

Superfluous store subscriptions after removing ignoreFilters

Without ignoreFilters: true, the hook now subscribes to searchQuery, sortField, and sortDirection from the filter store, but neither of these affects counts.pulls (the only field the sidebar uses). pullRequestCountQuery — the source of counts.pulls — only uses source_product, priority, and suggested_reviewers. The result is that every search keystroke and every sort-order change re-renders SidebarNavSection and re-runs the scopedReports memo (including filterReportsBySearch), without the badge value ever changing. It won't cause a visible bug but is extra work on a component that's always mounted. Consider adding a pullRequestsOnly path (or a narrower ignoreSearchAndSort flag) to prevent these subscriptions for the sidebar context.

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/ui/src/features/sidebar/components/SidebarNavSection.tsx
Line: 89

Comment:
**Superfluous store subscriptions after removing `ignoreFilters`**

Without `ignoreFilters: true`, the hook now subscribes to `searchQuery`, `sortField`, and `sortDirection` from the filter store, but neither of these affects `counts.pulls` (the only field the sidebar uses). `pullRequestCountQuery` — the source of `counts.pulls` — only uses `source_product`, `priority`, and `suggested_reviewers`. The result is that every search keystroke and every sort-order change re-renders `SidebarNavSection` and re-runs the `scopedReports` memo (including `filterReportsBySearch`), without the badge value ever changing. It won't cause a visible bug but is extra work on a component that's always mounted. Consider adding a `pullRequestsOnly` path (or a narrower `ignoreSearchAndSort` flag) to prevent these subscriptions for the sidebar context.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4d8c36502

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".