Fix/config external secret#215
Merged
Merged
Conversation
…AUTH Introduced a new helper template for managing the PORTKEY_CLIENT_AUTH environment variable, allowing for dynamic retrieval from a secret or fallback to a default value. This change enhances the modularity and maintainability of environment variable definitions across the portkey-app.
…figuration Updated the environment variable definitions in the helper template to mark all secret key references as optional. This change enhances flexibility in the configuration, allowing the application to function even if certain secrets are not available.
… reference is properly closed.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the portkey-app Helm chart helpers to better support external/managed secrets, particularly around PORTKEY_CLIENT_AUTH and log storage credential keys, by centralizing the PORTKEY_CLIENT_AUTH env var rendering and making several secretKeyRef lookups optional.
Changes:
- Added a reusable
portkey.clientAuthEnvhelper and used it in bothportkey.commonEnvandgateway.commonEnv. - Marked several log storage
secretKeyRefentries asoptional: trueto avoid hard failures when keys are absent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sk-portkey
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.