fix: mcp enable checks for deployment and service#209
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Helm templating conditionals for MCP-related ports so they only render when MCP is actually enabled, avoiding the prior behavior where a non-empty string result from include could make the condition always evaluate as “true”.
Changes:
- Update
Serviceports list to gate the MCP port on an explicit"true"value frommcp.enabled. - Update
Deploymentcontainer ports list to gate the MCP container port on an explicit"true"value frommcp.enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/portkey-gateway/templates/gateway/service.yaml | Fixes MCP port conditional to correctly evaluate the mcp.enabled helper result. |
| charts/portkey-gateway/templates/gateway/deployment.yaml | Fixes MCP container port conditional to correctly evaluate the mcp.enabled helper result. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avaya09
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.