Validate route filter definitions to reject spaces with clear error messages#40
Merged
Merged
Conversation
Co-authored-by: ondratu <6469029+ondratu@users.noreply.github.com>
Co-authored-by: ondratu <6469029+ondratu@users.noreply.github.com>
Co-authored-by: ondratu <6469029+ondratu@users.noreply.github.com>
Co-authored-by: ondratu <6469029+ondratu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error when there is space in filter route definition
Validate route filter definitions to reject spaces with clear error messages
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spaces in route filter definitions like
@app.route('/api/< id:int>')were either silently registered as static routes (causing runtime errors) or raised unclearRuntimeError: Undefined route group filter ':int 'messages.Changes
Added validation regex in
poorwsgi/wsgi.pyto detect spaces in filter definitions:<:< id:int>>:<id:int ><id :int><id: int>Enhanced
set_routemethod to validate URIs before processing and raiseValueErrorwith actionable error message including correct format examplesAdded test suite (
tests/test_route_validation.py) covering valid routes, invalid routes with spaces in various positions, and error message qualityError Message Improvement
Before:
After:
Note: Spaces within
:re:custom regex patterns remain valid, as they're part of the regex itself.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.