Skip to content

Pass llvm-cov env vars into tox#2630

Merged
ljeub-pometry merged 3 commits into
db_v4from
db_v4_/disk-ci-2
Jun 4, 2026
Merged

Pass llvm-cov env vars into tox#2630
ljeub-pometry merged 3 commits into
db_v4from
db_v4_/disk-ci-2

Conversation

@fabubaker
Copy link
Copy Markdown
Contributor

@fabubaker fabubaker commented Jun 3, 2026

What changes were proposed in this pull request?

Why are the changes needed?

To generate code coverage correctly over Python tests in https://github.com/Pometry/pometry-storage/pull/283.

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Are there any further changes required?

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 22128a9 Previous: 9823ef7 Ratio
lotr_graph/num_edges 4 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 4 ns/iter (± 0) 1 ns/iter (± 0) 4
lotr_graph/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph/iterate_exploded_edges 610825 ns/iter (± 2266) 285473 ns/iter (± 2920) 2.14
lotr_graph/graph_latest 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 8102013 ns/iter (± 19682) 1564816 ns/iter (± 35303) 5.18
lotr_graph_window_100/num_nodes 14 ns/iter (± 0) 5 ns/iter (± 0) 2.80
lotr_graph_window_100/iterate_exploded_edges 859370 ns/iter (± 10831) 325242 ns/iter (± 847) 2.64
lotr_graph_window_100_materialise/materialize 8495467 ns/iter (± 46863) 1669150 ns/iter (± 10700) 5.09
lotr_graph_window_10/has_node_existing 153 ns/iter (± 12) 62 ns/iter (± 11) 2.47
lotr_graph_window_10/iterate nodes 35082 ns/iter (± 114) 11339 ns/iter (± 40) 3.09
lotr_graph_window_10/iterate edges 103870 ns/iter (± 593) 48684 ns/iter (± 211) 2.13
lotr_graph_window_10/iterate_exploded_edges 416891 ns/iter (± 1543) 155788 ns/iter (± 1001) 2.68
lotr_graph_window_10_materialise/materialize 3711842 ns/iter (± 9558) 971980 ns/iter (± 4278) 3.82
lotr_graph_subgraph_10pc/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_subgraph_10pc_materialise/materialize 1954988 ns/iter (± 25456) 334634 ns/iter (± 1287) 5.84
lotr_graph_subgraph_10pc_windowed/has_node_existing 158 ns/iter (± 9) 62 ns/iter (± 14) 2.55
lotr_graph_subgraph_10pc_windowed/iterate nodes 5733 ns/iter (± 159) 1365 ns/iter (± 3) 4.20
lotr_graph_subgraph_10pc_windowed_materialise/materialize 1233495 ns/iter (± 58142) 230399 ns/iter (± 2617) 5.35
lotr_graph_window_50_layered/num_edges 79345 ns/iter (± 3145) 38714 ns/iter (± 1017) 2.05
lotr_graph_window_50_layered/num_edges_temporal 161072 ns/iter (± 1844) 70121 ns/iter (± 7586) 2.30
lotr_graph_window_50_layered/has_node_existing 477 ns/iter (± 24) 129 ns/iter (± 12) 3.70
lotr_graph_window_50_layered/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_window_50_layered/iterate nodes 80874 ns/iter (± 8056) 19308 ns/iter (± 47) 4.19
lotr_graph_window_50_layered/iterate edges 209076 ns/iter (± 535) 83616 ns/iter (± 1318) 2.50
lotr_graph_window_50_layered/max_neighbour_degree 776903 ns/iter (± 3040) 386651 ns/iter (± 3853) 2.01
lotr_graph_window_50_layered/graph_latest 82484 ns/iter (± 1099) 36649 ns/iter (± 916) 2.25
lotr_graph_window_50_layered_materialise/materialize 33784116 ns/iter (± 72998) 3488825 ns/iter (± 24948) 9.68
lotr_graph_persistent_window_50_layered/num_edges_temporal 659497 ns/iter (± 9345) 192686 ns/iter (± 1569) 3.42
lotr_graph_persistent_window_50_layered/has_node_existing 521 ns/iter (± 408) 174 ns/iter (± 83) 2.99
lotr_graph_persistent_window_50_layered/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_persistent_window_50_layered/iterate nodes 109603 ns/iter (± 2026) 35886 ns/iter (± 191) 3.05
lotr_graph_persistent_window_50_layered/iterate edges 193149 ns/iter (± 323) 84161 ns/iter (± 596) 2.29
lotr_graph_persistent_window_50_layered/iterate_exploded_edges 4853362 ns/iter (± 8225) 1659940 ns/iter (± 19402) 2.92
lotr_graph_persistent_window_50_layered/graph_latest 120332 ns/iter (± 1499) 57549 ns/iter (± 4809) 2.09
lotr_graph_persistent_window_50_layered_materialise/materialize 60840138 ns/iter (± 133630) 5298035 ns/iter (± 147912) 11.48

This comment was automatically generated by workflow using github-action-benchmark.

@fabubaker fabubaker changed the title Db v4 /disk ci 2 Pass llvm-cov env vars into tox Jun 3, 2026
@fabubaker fabubaker changed the title Pass llvm-cov env vars into tox Pass llvm-cov env vars into tox Jun 3, 2026
@ljeub-pometry ljeub-pometry merged commit 01a43fd into db_v4 Jun 4, 2026
6 checks passed
@ljeub-pometry ljeub-pometry deleted the db_v4_/disk-ci-2 branch June 4, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants