Skip to content

Fix/db v4 UI tests#2625

Merged
fabianmurariu merged 3 commits into
db_v4from
fix/db_v4_ui_tests
Jun 4, 2026
Merged

Fix/db v4 UI tests#2625
fabianmurariu merged 3 commits into
db_v4from
fix/db_v4_ui_tests

Conversation

@louisch
Copy link
Copy Markdown
Contributor

@louisch louisch commented May 27, 2026

What changes were proposed in this pull request?

Fixing the UI tests for v4 (and using windows runners for them)

Why are the changes needed?

UI tests are broken for v4 still, because:

  • the pipeline here still clones from the ui-tests repo, clobbering the tests we copy in via the make update-ui script
  • there were still parts of the UI/playwright testing that implicitly relied on things like node order or random seeding, which switching to v4/windows runners affect.

Does this PR introduce any user-facing change? If yes is this documented?

No

How was this patch tested?

Running the UI tests in pometry-ui and here.

Are there any further changes required?

If they're still broken I'll keep trying to fix them on this branch

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 42af36d Previous: 9823ef7 Ratio
lotr_graph/num_edges 5 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 5 ns/iter (± 0) 1 ns/iter (± 0) 5
lotr_graph/iterate_exploded_edges 585758 ns/iter (± 2435) 285473 ns/iter (± 2920) 2.05
lotr_graph/graph_latest 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 7820810 ns/iter (± 42156) 1564816 ns/iter (± 35303) 5.00
lotr_graph_window_100/num_nodes 13 ns/iter (± 0) 5 ns/iter (± 0) 2.60
lotr_graph_window_100/iterate_exploded_edges 779252 ns/iter (± 6434) 325242 ns/iter (± 847) 2.40
lotr_graph_window_100_materialise/materialize 8232195 ns/iter (± 75122) 1669150 ns/iter (± 10700) 4.93
lotr_graph_window_10/has_node_existing 147 ns/iter (± 7) 62 ns/iter (± 11) 2.37
lotr_graph_window_10/iterate nodes 31912 ns/iter (± 783) 11339 ns/iter (± 40) 2.81
lotr_graph_window_10/iterate_exploded_edges 393656 ns/iter (± 1305) 155788 ns/iter (± 1001) 2.53
lotr_graph_window_10_materialise/materialize 3637689 ns/iter (± 11823) 971980 ns/iter (± 4278) 3.74
lotr_graph_subgraph_10pc_materialise/materialize 1985488 ns/iter (± 21915) 334634 ns/iter (± 1287) 5.93
lotr_graph_subgraph_10pc_windowed/has_node_existing 152 ns/iter (± 6) 62 ns/iter (± 14) 2.45
lotr_graph_subgraph_10pc_windowed/iterate nodes 5458 ns/iter (± 162) 1365 ns/iter (± 3) 4.00
lotr_graph_subgraph_10pc_windowed_materialise/materialize 1246780 ns/iter (± 7658) 230399 ns/iter (± 2617) 5.41
lotr_graph_window_50_layered/num_edges_temporal 148773 ns/iter (± 1688) 70121 ns/iter (± 7586) 2.12
lotr_graph_window_50_layered/has_node_existing 443 ns/iter (± 18) 129 ns/iter (± 12) 3.43
lotr_graph_window_50_layered/iterate nodes 74291 ns/iter (± 1907) 19308 ns/iter (± 47) 3.85
lotr_graph_window_50_layered/iterate edges 191825 ns/iter (± 792) 83616 ns/iter (± 1318) 2.29
lotr_graph_window_50_layered/graph_latest 81341 ns/iter (± 2351) 36649 ns/iter (± 916) 2.22
lotr_graph_window_50_layered_materialise/materialize 32287092 ns/iter (± 75214) 3488825 ns/iter (± 24948) 9.25
lotr_graph_persistent_window_50_layered/num_edges_temporal 592176 ns/iter (± 5792) 192686 ns/iter (± 1569) 3.07
lotr_graph_persistent_window_50_layered/has_node_existing 468 ns/iter (± 300) 174 ns/iter (± 83) 2.69
lotr_graph_persistent_window_50_layered/iterate nodes 97958 ns/iter (± 1525) 35886 ns/iter (± 191) 2.73
lotr_graph_persistent_window_50_layered/iterate edges 180911 ns/iter (± 310) 84161 ns/iter (± 596) 2.15
lotr_graph_persistent_window_50_layered/iterate_exploded_edges 4385319 ns/iter (± 73475) 1659940 ns/iter (± 19402) 2.64
lotr_graph_persistent_window_50_layered/graph_latest 115137 ns/iter (± 1174) 57549 ns/iter (± 4809) 2.00
lotr_graph_persistent_window_50_layered_materialise/materialize 56994190 ns/iter (± 194764) 5298035 ns/iter (± 147912) 10.76

This comment was automatically generated by workflow using github-action-benchmark.

@louisch louisch force-pushed the fix/db_v4_ui_tests branch from 384e60d to 4debff6 Compare May 28, 2026 09:38
@louisch louisch force-pushed the fix/db_v4_ui_tests branch 4 times, most recently from e0df361 to 66419ea Compare June 2, 2026 17:49
@louisch louisch force-pushed the fix/db_v4_ui_tests branch from 66419ea to 42af36d Compare June 3, 2026 13:11
@fabianmurariu fabianmurariu merged commit f867964 into db_v4 Jun 4, 2026
34 checks passed
@fabianmurariu fabianmurariu deleted the fix/db_v4_ui_tests branch June 4, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants