Fix/db v4 UI tests#2625
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 42af36d | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
5 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
5 ns/iter (± 0) |
1 ns/iter (± 0) |
5 |
lotr_graph/iterate_exploded_edges |
585758 ns/iter (± 2435) |
285473 ns/iter (± 2920) |
2.05 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
7820810 ns/iter (± 42156) |
1564816 ns/iter (± 35303) |
5.00 |
lotr_graph_window_100/num_nodes |
13 ns/iter (± 0) |
5 ns/iter (± 0) |
2.60 |
lotr_graph_window_100/iterate_exploded_edges |
779252 ns/iter (± 6434) |
325242 ns/iter (± 847) |
2.40 |
lotr_graph_window_100_materialise/materialize |
8232195 ns/iter (± 75122) |
1669150 ns/iter (± 10700) |
4.93 |
lotr_graph_window_10/has_node_existing |
147 ns/iter (± 7) |
62 ns/iter (± 11) |
2.37 |
lotr_graph_window_10/iterate nodes |
31912 ns/iter (± 783) |
11339 ns/iter (± 40) |
2.81 |
lotr_graph_window_10/iterate_exploded_edges |
393656 ns/iter (± 1305) |
155788 ns/iter (± 1001) |
2.53 |
lotr_graph_window_10_materialise/materialize |
3637689 ns/iter (± 11823) |
971980 ns/iter (± 4278) |
3.74 |
lotr_graph_subgraph_10pc_materialise/materialize |
1985488 ns/iter (± 21915) |
334634 ns/iter (± 1287) |
5.93 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
152 ns/iter (± 6) |
62 ns/iter (± 14) |
2.45 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
5458 ns/iter (± 162) |
1365 ns/iter (± 3) |
4.00 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1246780 ns/iter (± 7658) |
230399 ns/iter (± 2617) |
5.41 |
lotr_graph_window_50_layered/num_edges_temporal |
148773 ns/iter (± 1688) |
70121 ns/iter (± 7586) |
2.12 |
lotr_graph_window_50_layered/has_node_existing |
443 ns/iter (± 18) |
129 ns/iter (± 12) |
3.43 |
lotr_graph_window_50_layered/iterate nodes |
74291 ns/iter (± 1907) |
19308 ns/iter (± 47) |
3.85 |
lotr_graph_window_50_layered/iterate edges |
191825 ns/iter (± 792) |
83616 ns/iter (± 1318) |
2.29 |
lotr_graph_window_50_layered/graph_latest |
81341 ns/iter (± 2351) |
36649 ns/iter (± 916) |
2.22 |
lotr_graph_window_50_layered_materialise/materialize |
32287092 ns/iter (± 75214) |
3488825 ns/iter (± 24948) |
9.25 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
592176 ns/iter (± 5792) |
192686 ns/iter (± 1569) |
3.07 |
lotr_graph_persistent_window_50_layered/has_node_existing |
468 ns/iter (± 300) |
174 ns/iter (± 83) |
2.69 |
lotr_graph_persistent_window_50_layered/iterate nodes |
97958 ns/iter (± 1525) |
35886 ns/iter (± 191) |
2.73 |
lotr_graph_persistent_window_50_layered/iterate edges |
180911 ns/iter (± 310) |
84161 ns/iter (± 596) |
2.15 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
4385319 ns/iter (± 73475) |
1659940 ns/iter (± 19402) |
2.64 |
lotr_graph_persistent_window_50_layered/graph_latest |
115137 ns/iter (± 1174) |
57549 ns/iter (± 4809) |
2.00 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
56994190 ns/iter (± 194764) |
5298035 ns/iter (± 147912) |
10.76 |
This comment was automatically generated by workflow using github-action-benchmark.
384e60d to
4debff6
Compare
e0df361 to
66419ea
Compare
66419ea to
42af36d
Compare
miratepuffin
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixing the UI tests for v4 (and using windows runners for them)
Why are the changes needed?
UI tests are broken for v4 still, because:
make update-uiscriptDoes this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Running the UI tests in pometry-ui and here.
Are there any further changes required?
If they're still broken I'll keep trying to fix them on this branch