Annotation Refactor#35
Open
Pollux12 wants to merge 25 commits into
Open
Conversation
This gives an alternative to union and allows for increased precision without potentially noisy diagnostics as a result of that union. Rather than adding to a union, the language server can instead keep the generic type but register something as a potential default, so if not specified, it will use that value.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Three fixes found during review of the annotation refactor: - perf: GmodClassMetadataIndex::add_call rebuilt the entire panel/skin cache on every re-add. Because scripted-class collection runs in both the pre- and post-analysis passes, every call was re-added once, making a full analysis O(calls * total_calls). Refresh only the re-added call's cache contribution incrementally instead. - fix: the LS string-context arg->param conversion (adjusted_arg_index) adjusted on is_colon_call alone, diverging from the analyzer's param_idx_to_call_arg_idx for colon-defined methods (e.g. Entity:NetworkVar). Route all sites through one is_colon_define-aware helper so colon-called colon-defined functions resolve correctly. - cleanup: drop redundant format!(...).to_string() in undefined_global. Adds unit tests for the arg-index conversion (all four colon combinations) and for incremental cache stability on re-add. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains an overhaul for many previously hardcoded special Garry's Mod specific cases by moving it all to be annotation based rather than string based matches, alongside several bug fixes.