Certify policyengine.py against policyengine-core 3.30.0#465
Merged
Conversation
1eaec61 to
97142b2
Compare
Update the bundle manifest (the source of truth for package pins) to policyengine-core 3.30.0 via scripts/bundle.py update-packages --core, then regenerate the derived pyproject pins, uv.lock, and the vendored TRACE TRO sidecars (which bind the bundle manifest by sha256). 3.30.0 enforces formula-time determinism with a static check at variable registration (policyengine-core#518) and fixes Reform.from_dict bare-date period semantics (#510). Verified both country systems build under 3.30.0 with no NonDeterministicFormulaError (us 1.764.6: 5770 variables; uk 2.89.2: 869 variables); pinned packages already allow policyengine-core>=3.26.0, so no country-package bump is needed. bundle.py check and the TRO sidecar-binding test pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
97142b2 to
ffadc15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #464
Summary
Bumps the pinned
policyengine-corefrom 3.28.0 → 3.30.0 across themodels/us/uk/devextras, and regeneratesuv.lock.Why
3.30.0 brings two upstream fixes relevant to policyengine.py:
numpy.random. That guard raised intermittent, misattributedNonDeterministicFormulaErrors when multiple simulations were built or run concurrently in one process — the pattern policyengine.py exercises.Reform.from_dictbare-date period semantics (from-onward vs bounded).Country packages — no bump needed
The pinned packages already allow the new core and are randomness-clean:
policyengine-us==1.764.6→ requirespolicyengine-core>=3.26.0policyengine-uk==2.89.2→ requirespolicyengine-core>=3.26.0Certification
With core 3.30.0 installed against these pins, both country systems build with no
NonDeterministicFormulaError(the new static check runs on every variable at registration):make formatandmake lintare clean. Full model/data test runs are left to CI (they requireHUGGING_FACE_TOKEN).🤖 Generated with Claude Code