Restore Pennsylvania property tax or rent rebate to 2026 aggregate#9006
Open
DTrim99 wants to merge 2 commits into
Open
Restore Pennsylvania property tax or rent rebate to 2026 aggregate#9006DTrim99 wants to merge 2 commits into
DTrim99 wants to merge 2 commits into
Conversation
pa_property_tax_or_rent_rebate was present in the 2024 and 2025 blocks of state_property_tax_credits.yaml but was dropped from the 2026 block when the Indiana over-65 credit PR (PolicyEngine#8308) created a fresh 2026 list. This silently zeroed the Pennsylvania rebate in 2026 microsimulations. Its parameters carry their 2025 values forward, so the program continues unchanged in 2026. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Guards against pa_property_tax_or_rent_rebate being dropped from the 2026 state property tax credits list again: a qualifying 2026 PA household must see the rebate flow through taxsim_state_property_tax_credit. Uses the vt_renter_credit_in_aggregate.yaml pattern. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
Independent review + fixes appliedIndependent review confirmed the one-line restore is correct and low-risk (the PA Property Tax/Rent Rebate is ongoing, its parameters carry 2025 values forward, and it appears exactly once in the 2026 list). No critical issues. Applied the findings: 🟡 Should Address
🟢 Suggestions — applied
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores
pa_property_tax_or_rent_rebateto the 2026 block ofstate_property_tax_credits.yaml.It was present in the 2025 block but was dropped from the 2026 block when the Indiana over-65 credit PR (#8308) created a fresh 2026 list — the same accidental merge collision that dropped
nd_renters_refund(restored separately in #8996). The omission silently zeroed the Pennsylvania Property Tax/Rent Rebate in 2026 microsimulations.Why this is correct
The Property Tax/Rent Rebate is an ongoing program with no 2026 sunset. Its parameters (amount schedule, income limit) carry their 2025 values forward, so restoring it to the 2026 aggregate makes it compute exactly as it did in 2025 — which is the intended behavior.
Changes
pa_property_tax_or_rent_rebateback to the 2026 block (alphabetical position, matching 2025).No new variables or parameters — this is purely the accidentally-dropped aggregate entry.
🤖 Generated with Claude Code