Add decomposed marginal tax rate variables (federal, state, FICA)#7791
Open
PavelMakarchuk wants to merge 5 commits intomainfrom
Open
Add decomposed marginal tax rate variables (federal, state, FICA)#7791PavelMakarchuk wants to merge 5 commits intomainfrom
PavelMakarchuk wants to merge 5 commits intomainfrom
Conversation
Closes #7790 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use person.household.sum() with is_tax_unit_head filter for consistency with how marginal_tax_rate uses household_net_income - Add married couple and multi-tax-unit household tests for each variable (15 tests total) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PavelMakarchuk
requested review from
MaxGhenis
and removed request for
MaxGhenis
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7791 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 4 +1
Lines 33 61 +28
Branches 0 3 +3
=========================================
+ Hits 33 61 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7790
federal_marginal_tax_rate— marginal change in federal income tax per dollar of additional earningsstate_marginal_tax_rate— marginal change in state income tax per dollar of additional earningsfica_marginal_tax_rate— marginal change in employee payroll tax per dollar of additional earningsThese enable apples-to-apples comparison with TAXSIM-35 outputs (
frate,srate,ficar) and are independently useful for decomposing where marginal rates come from.Each variable follows the same counterfactual branch pattern as
marginal_tax_rate(perturb earnings by delta, measure change in specific tax component), with unique branch names to avoid conflicts.Test plan
marginal_tax_ratetests still passmake formatpasses🤖 Generated with Claude Code