Add selected loss.py targets to unified calibration#946
Open
anth-volk wants to merge 1 commit into
Open
Conversation
MaxGhenis
approved these changes
May 14, 2026
Contributor
MaxGhenis
left a comment
There was a problem hiding this comment.
Reviewed the target-selection additions, ETL insertion points, and unit coverage. The new SOI positive-domain strata, EITC claimant counts, ACS rent targets, Medicare Part B age buckets, and target_config rules look consistent with the unified calibration flow, and CI is green. No blockers from my review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #945
Requesting review from @MaxGhenis to confirm that we want these targets in US.h5 and state/district-level datasets.
Summary
Targets Added
Exact target-selection rules added to
policyengine_us_data/calibration/target_config.yaml:household_countstatesnaprentstatetax_unit_countstateeitctax_unit_countstatereal_estate_taxes,tax_unit_itemizestax_unit_countnationaladjusted_gross_income,income_tax_before_credits,irs_employment_incomeirs_employment_incomenationaladjusted_gross_income,income_tax_before_credits,irs_employment_incometax_unit_countnationaladjusted_gross_income,filing_status,income_tax_before_credits,irs_employment_incomeirs_employment_incomenationaladjusted_gross_income,filing_status,income_tax_before_credits,irs_employment_incometax_unit_countnationaladjusted_gross_income,income_tax_before_credits,pension_incomepension_incomenationaladjusted_gross_income,income_tax_before_credits,pension_incometax_unit_countnationaladjusted_gross_income,filing_status,income_tax_before_credits,pension_incomepension_incomenationaladjusted_gross_income,filing_status,income_tax_before_credits,pension_incometax_unit_countnationaladjusted_gross_income,income_tax_before_credits,social_securitysocial_securitynationaladjusted_gross_income,income_tax_before_credits,social_securitytax_unit_countnationaladjusted_gross_income,filing_status,income_tax_before_credits,social_securitysocial_securitynationaladjusted_gross_income,filing_status,income_tax_before_credits,social_securitymedicare_part_b_premiumnationalagehousehold_countnationalspm_unit_energy_subsidy_reportedrefundable_american_opportunity_creditnationalrefundable_american_opportunity_crediteducation_tax_creditsnationaleducation_tax_creditstax_unit_countnationalrefundable_american_opportunity_credittax_unit_countnationaleducation_tax_creditstax_unit_countnationalreal_estate_taxes,tax_unit_itemizesNew ETL target rows introduced by this PR:
tax_unit_countby state whereeitc > 0, sourced from IRS EITC Central controls.rentby state, sourced fromacs_housing_costs_YEAR.csv/ ACS B25060.medicare_part_b_premiumnationally by 10-yearagebuckets, sourced fromhealthcare_spending.csv.irs_employment_income,pension_income, andsocial_security, with matching positive-domaintax_unit_countrows, sourced from tracked SOI Table 1.4 targets.Verification
Notes