Fix pandas 3.0 StringArray compatibility in ParameterNodeAtInstant #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParameterNodeAtInstant.__getitem__() now converts pandas StringArray to numpy array before checking for fancy indexing. Without this fix, passing a StringArray as a key raises: TypeError: unhashable type: 'StringArray' This mirrors the existing fix in VectorialParameterNodeAtInstant. Fixes #429 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ParameterNodeAtInstant.__getitem__()to convert pandas StringArray to numpy array before using for fancy indexingProblem
In pandas 3.0, string columns use StringDtype by default, producing StringArray objects. When a StringArray is passed to
ParameterNodeAtInstant.__getitem__(), it fails with:This is because StringArray is not hashable and can't be used as a dict key in
self._children[key].Solution
Added the same check that already exists in
VectorialParameterNodeAtInstant.__getitem__():This converts pandas arrays (like StringArray) to numpy arrays before checking for fancy indexing.
Test plan
test_parameter_node_at_instant_getitem_with_string_arrayFixes #429
🤖 Generated with Claude Code