Remove stale smoke test workaround #426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Python 3.13 special handling (tables now has 3.13 wheels) - Remove unused dependencies: synthimpute, click, pathlib, pytest-dependency, tabulate - Remove stale comment in setup.py Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 81.14% 82.45% +1.31%
==========================================
Files 197 202 +5
Lines 10228 10585 +357
Branches 1057 1066 +9
==========================================
+ Hits 8299 8728 +429
+ Misses 1640 1582 -58
+ Partials 289 275 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clean up stale smoke test workaround that installed unused dependencies.
Changes
synthimpute,click,pathlib,pytest-dependency,tabulateWhy
The workaround was added when tables didn't have Python 3.13 wheels. Now that tables>=3.10.2 supports 3.13, the workaround is unnecessary. The dependencies it installed (especially synthimpute) haven't been used by PolicyEngine in a long time.
Test plan
pip install policyengine-usworks on Python 3.10-3.13🤖 Generated with Claude Code