-
Notifications
You must be signed in to change notification settings - Fork 26
Add Python 3.14 support #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MaxGhenis
wants to merge
8
commits into
PolicyEngine:master
Choose a base branch
from
MaxGhenis:add-python-3.14-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Python 3.14 to classifiers in setup.py - Add Python 3.14 to Test matrix in pr.yaml - Add Python 3.14 to SmokeTestForMultipleVersions matrix - Handle Python 3.14 like 3.13 for tables package workaround The numpy compatibility fix for Python 3.14 was already merged in PR PolicyEngine#409. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 81.14% 82.45% +1.31%
==========================================
Files 197 202 +5
Lines 10228 10585 +357
Branches 1057 1066 +9
==========================================
+ Hits 8299 8728 +429
+ Misses 1640 1582 -58
+ Partials 289 275 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
tables doesn't have Python 3.14 wheels yet, so the smoke tests with policyengine-us will fail. The core tests pass on Python 3.14. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Will merge when tables has Python 3.14 wheels. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
tables 3.11+ will have Python 3.14 wheels (PyTables/PyTables#1262). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Core tests still run on 3.14 (and pass). Smoke tests with policyengine-us excluded until tables has Python 3.14 support. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
CI failure signals PR is blocked. When tables 3.11 releases, CI will auto-pass and PR is ready to merge. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The old workaround installed unnecessary deps (synthimpute, etc.). Just let policyengine-us install normally - it will fail on Python 3.14 until tables 3.11 releases, then auto-work. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Python 3.14 support to policyengine-core.
Status: Blocked on tables
Once tables 3.11.0 ships with Python 3.14 support, this PR can be merged.
Changes
tablespackage workaroundWhat works now
What's blocked
Dependencies
The numpy compatibility fix for Python 3.14 was already merged in PR #409.
Test plan
Related issue
Fixes #399
🤖 Generated with Claude Code