-
Notifications
You must be signed in to change notification settings - Fork 145
Implementation for replacement of hardcoded API URLs with config-base… #2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
SongmingFan123
wants to merge
1
commit into
master
from
issue-2492-replace-hardcoded-API-URLs-with-config-based-approach
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Development API Configuration | ||
| REACT_APP_API_URL=https://api.policyengine.org | ||
| REACT_APP_API_AUDIENCE=https://api.policyengine.org/ | ||
|
|
||
| # Development mode flag | ||
| REACT_APP_DEBUG=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # API Configuration | ||
| REACT_APP_API_URL=https://api.policyengine.org | ||
| REACT_APP_API_AUDIENCE=https://api.policyengine.org/ | ||
|
|
||
| # Development mode | ||
| REACT_APP_DEBUG=true | ||
|
|
||
| # For local development, uncomment these and use appropriate URLs | ||
| # REACT_APP_API_URL=http://localhost:5000 | ||
| # REACT_APP_API_AUDIENCE=http://localhost:5000/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Production API Configuration | ||
| REACT_APP_API_URL=https://api.policyengine.org | ||
| REACT_APP_API_AUDIENCE=https://api.policyengine.org/ | ||
|
|
||
| # Debug mode should be off in production | ||
| REACT_APP_DEBUG=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /** | ||
| * Configuration values for the application | ||
| * These can be overridden by environment variables | ||
| */ | ||
|
|
||
| // API URLs | ||
| export const API_URL = process.env.REACT_APP_API_URL || "https://api.policyengine.org"; | ||
| export const API_AUDIENCE = process.env.REACT_APP_API_AUDIENCE || "https://api.policyengine.org/"; | ||
|
|
||
| // Auth configuration (moved from authUtils.js for centralization) | ||
| export const AUTH0_DOMAIN = "policyengine.uk.auth0.com"; | ||
| export const AUTH0_CLIENT_ID = "jbAXjeFRxGpGRxkedjt2wRLHJd26bwDS"; | ||
|
|
||
| // Redirect URL for Auth0 | ||
| export const AUTH0_REDIRECT_URI = process.env.REACT_APP_DEBUG | ||
| ? "http://localhost:3000/callback" | ||
| : "https://policyengine.org/callback"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider ensuring consistent slash usage when concatenating API_URL with path, as the API_URL and API_AUDIENCE values use different trailing slash conventions. A utility function or normalization could prevent potential URL concatenation issues.