Skip to content

Api url 2493 #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fudgemasterultra wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Api url 2493 #2510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9c3b33
adding in .env.example file updated ignore, and swapped out for env v…
fudgemasterultra Apr 28, 2025
1792484
make file to copy .env.example on install, and added default value re…
fudgemasterultra Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
REACT_APP_POLICYENGINE_API=https://api.policyengine.org
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,4 @@ yarn-error.log*
.idea

venv/*
.env
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ REACT_APP_DEBUG ?= false

install:
npm ci
cp .env.example .env
pip3 install -U black

build:
Expand Down
18 changes: 10 additions & 8 deletions src/api/call.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import { buildVariableTree, getTreeLeavesInOrder } from "./variables";
import { wrappedJsonStringify, wrappedResponseJson } from "../data/wrappedJson";
import { useAuthenticatedFetch } from "../hooks/useAuthenticatedFetch";

const POLICYENGINE_API = "https://api.policyengine.org";

/**
* returns an api call function that can be used to make requests
* against the policyengine api endpoint.
Expand Down Expand Up @@ -47,13 +45,17 @@ export function apiCall(
secondAttempt = false,
fetchMethod = fetch,
) {
return fetchMethod(POLICYENGINE_API + path, {
method: method || (body ? "POST" : "GET"),
headers: {
"Content-Type": "application/json",
return fetchMethod(
process.env.REACT_APP_POLICYENGINE_API ||
Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Would it be more advantageous to set the POLICYENGINE_API constant as either the env var or standard address, then use that constant in the fetch method?

This would enable other components, as needed, to import the constant

"https://api.policyengine.org" + path,
{
method: method || (body ? "POST" : "GET"),
headers: {
"Content-Type": "application/json",
},
body: body ? wrappedJsonStringify(body) : null,
},
body: body ? wrappedJsonStringify(body) : null,
}).then((response) => {
).then((response) => {
// If the response is a 500, try again once.
if (response.status === 500 && !secondAttempt) {
return apiCall(path, body, method, true);
Expand Down
Loading