Shiny hunt fishing#1146
Open
Developer-Butters wants to merge 3 commits intoPokemonAutomation:mainfrom
Open
Conversation
Added the Shiny hunt fishing files to the rpo. no modifications made to the FRLG Panels.cpp or source files saved with this commit. Implements an automated fishing-based shiny hunting program for FRLG. Features: - Adaptive timing system that adjusts button press delay based on missed bites - Encounter detection using dialog and battle transition watchers - Shiny detection using existing encounter handling logic - Stats tracking for encounters, shinies, and errors - Notification support when a shiny is found - Configurable bite timing window - Compatible with registered rod workflow Code structure follows existing FRLG program patterns: - Descriptor + Instance class structure - Standard StatsTracker implementation - EventNotificationOption owned by program class - Consistent namespace and option registration layout Future improvements planned: - Optional rod auto-registration - Optional audio-based shiny detection redundancy - Periodic autosave support - Ball selection and auto-catch workflow
Reduce extra spacing and clarify adaptive timing, fail-safe logic, and detectors. Added program to PokemonFRLG_Panels.cpp and to SourceFiles.cmake. No functional changes.
I think the python string that adds programs to sourcefiles.cmake makes a lot of changes to the order. To minimize the apparent changes, I copied the original file and manually added my programs to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fishing-based shiny hunt program for FRLG.
This attempt should address all concerns about formatting.
The program automatically casts the registered fishing rod, detects bite dialogs, adapts timing for reliable hook success, and handles encounters using existing FRLG navigation and battle logic. It checks the pokemon for shininess when encountered and flees if not shiny.