Add FRLG fishing shiny hunt program#1145
Closed
Developer-Butters wants to merge 0 commit intoPokemonAutomation:mainfrom
Closed
Add FRLG fishing shiny hunt program#1145Developer-Butters wants to merge 0 commit intoPokemonAutomation:mainfrom
Developer-Butters wants to merge 0 commit intoPokemonAutomation:mainfrom
Conversation
Collaborator
|
Thanks for this! However, this does looks vibe-coded. Vibe-coding is fine, but you need to understand and review what the AI has generated so that you know it as well as if you wrote it yourself.
|
Collaborator
|
It looks like your PR still has made lots of changes to CMakeLists.txt. See the |
76a2493 to
345be78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fishing-based shiny hunt program for FRLG.
Includes adaptive bite timing, automatic rod registration, correct encounter
counting, and integration with the existing shiny detection pipeline.
Follows structure used by other FRLG programs and improves loop speed compared
to static timing approaches.