Merged
Conversation
Collaborator
|
How difficult would it be to make the backend toggleable between the dual recording vs. this new one? |
Mysticial
reviewed
Jan 30, 2026
| return img.convertToFormat(QImage::Format_BGR888); | ||
| } | ||
|
|
||
| std::vector<uchar> compress_video_frame(const QVideoFrame& const_frame) { |
Collaborator
There was a problem hiding this comment.
Is this running on the main Qt thread?
Collaborator
Author
It's doable. But I figured we should fix the dual recording's memory leak first. Before we enable that as an option. |
Mysticial
reviewed
Feb 6, 2026
| // cout << "on_frame() = " << m_frames.size() << endl; | ||
|
|
||
| // Initialize on first frame | ||
| if (m_next_frame_time == WallClock{}){ |
Collaborator
There was a problem hiding this comment.
I'd initialize m_next_frame_time to WallClock::min() in the constructor. Then test against that here. It's unclear what WallClock{} initializes to.
Collaborator
|
Just that one minor comment. Feel free to merge. (don't wait for me since I'll be busy for a while.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.