Add Sword/Shield encounters (Part 2)#1564
Conversation
…-route-2-main fishing
…alar-battle-tower for consistency
…ate location areas
…/add-sword-shield-encounters
…/add-sword-shield-encounters
|
Not sure why that CSV step is failing in the automated checks.. maybe someone can comment on that? Edit: Just missing some commas! The log was very clear with the issue that needed to be fixed lol |
…/add-sword-shield-encounters
…/add-sword-shield-encounters
|
Hi! Let's separate those versions then You can go with the size you prefer, I don't mind small or big updates. |
| 22,9,Bug-Catching Contest | ||
| 23,9,Have save data from another Pokémon game | ||
| 24,9,Find a certain number of Alolan Diglett in Isle of Armor | ||
| 25,9,Specific weather |
There was a problem hiding this comment.
What's specific weather? An in game condition called like that?
If not we could be more specific
There was a problem hiding this comment.
This is more for the broad category, the encounter condition values I've made more specific. But yes, this was a placeholder that I had meant to write more into so let me do that
| 53,pokespot,53 | ||
| 54,hidden-grotto,54 | ||
| 55,honey-tree,54 | ||
| 55,honey-tree,55 |
| 847,9,Route 4 | ||
| 848,9,Route 5 | ||
| 849,9,Route 6 | ||
| 843,9,Galar Route 1 |
There was a problem hiding this comment.
Do we need the 'galar' suffix here?
There was a problem hiding this comment.
After looking through, no not at all! I saw some newer additions to Unova routes with Hidden Grotto and I had assumed the rest had that region identifier in the prose. But those were the only ones - I went ahead and removed the Galar (and Unova) prefixes to these routes' prose.
…unova hidden grotto areas
…/add-sword-shield-encounters
Change description
The continuation of PR #1550, addressing issue #1459. I've reviewed each of the location areas as I usually do for encounter PRs that I review formally to try and catch as many mistakes as possible.
This PR adds encounters for every single location in-game aside from wild areas including all gifts and trades for Sword/Shield and its DLCs. In addition, I've also added one wild area: Rolling Fields.
Encounter Conditions
This PR adds new encounter conditions for save data, finding Alolan Diglett across the Isle of Armor, and weather conditions. The relevant condition values (i.e. which save data, how many Diglett, and what weather conditions) were added to describe the encounters. Relevant prose was added.
Encounter methods
A new encounter method,
overworld-dirt, was used for Pokemon that come from underground and spawn in the overworld. Relevant prose was added.Locations
A new location for Galar Energy Plant was added.
Location areas
Missing prose was added for each location area that gained encounters. New areas were added as needed, and existing areas were removed/renamed to be consistent.
I also renamed the Galar routes' prose to have "Galar" in the name, like the other regions.
Coming in later PRs
I intend to continue adding new wild areas, but they are massive. Rolling Fields takes up over half of the encounters added in #1550 and this PR combined. There are many wild areas to add, and each location area in the DLCs are wild areas.
Additionally, I've noticed an issue with our versions. There are version exclusives in the DLCs, but we lump both versions' DLC into one version (i.e.
the-isle-of-armorinstead ofsword-the-isle-of-armorandshield-the-isle-of-armor). To accurately document version-exclusive encounters between Sword/Shield, we either need to add some DLC condition (which would get tiresome) or add these new versions tied to the relevant version group and restructure some existing entries in the API. For the moment, the gifts/trades I added from the DLC are tied to Sword/Shield rather than the relevant DLC for simplicity, but I intend to fix this in a separate PR dedicated to this specific fix.@Naramsim I've added all of this in one large PR as I got the impression that you'd rather add this data in so we have the encounters we've been missing now and we can check things later, since I tend to work with encounters closely. If you'd rather smaller chunks as I mentioned in the past PR, let me know and I can break things apart for easier checks.
AI coding assistance disclosure
No AI used.
Contributor check list