Skip to content

Added --log-type option with ability to load diagnostic log files.#406

Merged
adamshapiro0 merged 17 commits into
masterfrom
load-diag
May 4, 2026
Merged

Added --log-type option with ability to load diagnostic log files.#406
adamshapiro0 merged 17 commits into
masterfrom
load-diag

Conversation

@adamshapiro0
Copy link
Copy Markdown
Collaborator

@adamshapiro0 adamshapiro0 commented May 4, 2026

New Features

  • Added --log-type option with ability to load diagnostic log files in addition to user output files (fusion_engine.p1log, etc.)
  • Added unit tests for log.py

Changes

  • Support both legacy maniphest.json and correct manifest.json spellings

Fixes

  • Fixed handling of non-existent log files/directories
  • Fixed extraction of log ID from manifest or file in a subdirectory

adamshapiro0 added 17 commits May 4, 2026 09:03
@adamshapiro0
Load diagnostics.p1log as a fallback if fusion_engine.p1log does not …
fa1616a 
…exist.
@adamshapiro0
Documented candidate file locations.
37b0320
@adamshapiro0
Added extract_fusion_engine_log(message_types) option.
6a0f23f
@adamshapiro0
Removed deprecated path from find_p1log_file().
45f6768
@adamshapiro0
Added --log-type option to select which input file to load.
d73c484
@adamshapiro0
Support both legacy and correct manifest filename spellings.
a66726b
@adamshapiro0
Minor clarity cleanup for log search.
af58926
@adamshapiro0
Moved manifest->input file search to helper function.
798c0fe
@adamshapiro0
Search all candidate files by default in find_log_file().
a367ebd
@adamshapiro0
Check for any input file indicated by the log manifest.
01a973b
@adamshapiro0
Added log.py unit tests.
c5fb6ef
@adamshapiro0
Fixed handling of non-existent log file/directory.
9878e2a
@adamshapiro0
Fixed extraction of log ID from manifest or file in a subdirectory.
6c8b7a6
@adamshapiro0
Create manifest files by default for unit test logs.
6ad9ec0
@adamshapiro0
Removed incorrect test.
38a1d50 
diag _should_ return the input file from the manifest file - the input file is
considered diagnostic and presumed to have FusionEngine data in it. If it is an
RTCM file, etc., we will parse it but will not find any FusionEngine messages.
@adamshapiro0
Fixed log ID/dir returns when locating a data file from a manifest.
56d71ff
@adamshapiro0
Fixed variable shadowing in _get_log_id().
e2b0333
@adamshapiro0 adamshapiro0 requested a review from bhers4 May 4, 2026 19:13
@adamshapiro0 adamshapiro0 self-assigned this May 4, 2026
bhers4
bhers4 approved these changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhers4 bhers4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@adamshapiro0 adamshapiro0 merged commit a737b55 into master May 4, 2026
27 checks passed
@adamshapiro0 adamshapiro0 deleted the load-diag branch May 4, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhers4 bhers4 bhers4 approved these changes

Assignees

@adamshapiro0 adamshapiro0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamshapiro0 @bhers4