Improve ModelRegistry item assignment error - #254
Open
russlan23 wants to merge 1 commit into
Open
Conversation
Signed-off-by: russlan23 <rrusslanjr@gmail.com>
russlan23
requested review from
feussy,
hintse,
ptomecek and
timkpaine
as code owners
August 9, 2026 03:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #162.
Adds an explicit
ModelRegistry.__setitem__error that directs users to the controlledaddAPI. The regression verifies the message and confirms that a failed assignment leaves the registry unchanged.Type of Change
Validation
python -m pytest -q ccflow/tests/test_base_registry.py- 43 passedpython -m ruff check ccflow/base.py ccflow/tests/test_base_registry.py- passedpython -m ruff format --check ccflow/base.py ccflow/tests/test_base_registry.py- passedgit diff --check- passedA clean full-suite attempt could not install the complete optional development extra because the package download timed out; the repository CI can provide the full declared matrix.
Checklist
make testpasses locally