-
Notifications
You must be signed in to change notification settings - Fork 2
Update dependencies and Python version #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Grimpy101
wants to merge
22
commits into
Podnapisi-NET:master
Choose a base branch
from
Grimpy101:python-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
195036d
Update dependencies
Grimpy101 144b90b
Update BaseBackend class
Grimpy101 4f2dc48
Update UserAcl
Grimpy101 71249f7
Update UserAcl
Grimpy101 2e22b85
Update Python version in mypy config
Grimpy101 4a98464
Modify BaseBackend.execute method to improve typing
Grimpy101 0dd3ff0
Update Psycopg2Backend
Grimpy101 fb2e7b7
Remove absolute_import
Grimpy101 fb9a1f4
Bump Python version in configs
Grimpy101 68ef44f
Update imports in psycopg2.py, extensions.py, and sessions.py
Grimpy101 2a3e0d8
Update PhpBB3, reassign phpbb3_backend from flask._app_ctx_stack to f…
Grimpy101 d47b447
Update sessions.py, add error handling in extension.py
Grimpy101 2c571ed
Add comments
Grimpy101 39a6f90
Fixing tests WIP
Grimpy101 6980284
Update requirements, adjust tests for this Flask version
Grimpy101 a1c214e
Format tests
Grimpy101 90be040
Update package building
Grimpy101 84ff723
Switch ordering of classes to make types Python 3.8 compatible, updat…
Grimpy101 6ff847b
Switch to uv package management
Grimpy101 3399d66
Unify module imports
Grimpy101 31818e0
Specify definite typing based on context, change inharitance to pytho…
Grimpy101 e7ecc93
Format files with Black formatter
Grimpy101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| psycopg2>=2.4.5 | ||
| Flask>=0.10 | ||
| typing | ||
| psycopg2>=2.9.11 | ||
| Flask>=3.1.2 | ||
| cachelib>=0.13.0 | ||
| setuptools>=80.9.0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| -r ../requirements.txt | ||
| flake8 | ||
| flake8-import-order | ||
| coverage | ||
| mock | ||
| coverage |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependencies should be more "inclusive" regarding dependencies. Is latestflask really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can probably lower the Flask version to 2.3.0 (this is where support for Python 3.7 was dropped and most breaking changes were introduced). For psycopg2, version 2.9.10 would likely suffice (that's where the support for Python 3.7 was dropped as well), although I need to check if it is compatible with Python 3.14 ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make intermediate version to have 3.8 version supported.
Afaik, only podnapisi.net uses this library :) .