Skip to content

feat: [PPT-2270] 1-click setup for outlook plugin #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stakach merged 3 commits into from
Dec 16, 2025

Merge branch 'master' into PPT-2270

802eeb0
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: [PPT-2270] 1-click setup for outlook plugin #420

Merge branch 'master' into PPT-2270
802eeb0
Select commit
Loading
Failed to load commit list.
GitHub Actions / Ameba failed Dec 16, 2025 in 2s

Crystal Ameba Results

Total files checked: 113
Issues found: 7

Ameba Version: 1.6.4
Crystal Version: 1.14.0

Annotations

Check warning on line 404 in spec/controllers/uploads_spec.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/UselessAssign 

Useless assignment to variable `authority`
Raw output 
> authority = Model::Authority.find_by_domain("localhost").not_nil!
  ^

Check warning on line 426 in spec/controllers/uploads_spec.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/UselessAssign 

Useless assignment to variable `authority`
Raw output 
> authority = Model::Authority.find_by_domain("localhost").not_nil!
  ^

Check warning on line 122 in src/placeos-rest-api/utilities/ms-token-exchange.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/ShadowingOuterLocalVar 

Shadowing outer local variable `form`
Raw output 
> form = URI::Params.build do |form|
                               ^

Check warning on line 193 in src/placeos-rest-api/utilities/ms-token-exchange.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/UselessAssign 

Useless assignment to variable `info`
Raw output 
> info = token_info || peek_token_info(token)
  ^

Check notice on line 29 in src/placeos-rest-api/utilities/ms-token-exchange.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/PredicateName 

Favour method name 'ms_token?' over 'is_ms_token?'
Raw output 
> def is_ms_token? : Bool
      ^

Check notice on line 166 in src/placeos-rest-api/utilities/ms-token-exchange.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/RedundantBegin 

Redundant `begin` block detected
Raw output 
> begin
  ^

Check notice on line 177 in src/placeos-rest-api/utilities/ms-token-exchange.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/RedundantBegin 

Redundant `begin` block detected
Raw output 
> begin
  ^
View more details on GitHub Actions