Skip to content

Add log redirect #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtarit merged 1 commit into from
Apr 5, 2026
Merged

Add log redirect #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/routes/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,4 +177,12 @@ def get(self, short_code):
REDIRECT_NOT_FOUND.inc()
abort(404, message="URL is not active")
REDIRECT_TOTAL.inc()
Event.create(
url_id=url.id,
user_id=url.user_id,
event_type="redirect",
timestamp=datetime.now(),
details=json.dumps({"short_code": short_code, "original_url": url.original_url}),
)
EVENT_RECORDED.labels(event_type="redirect").inc()
return redirect(url.original_url, code=302)
5 changes: 5 additions & 0 deletions tests/integration/test_urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,14 @@ def test_delete_url_not_found(client):


def test_redirect_url(client, sample_url):
from app.models.event import Event

res = client.get("/urls/abc123/redirect")
assert res.status_code == 302
assert res.headers["Location"] == "https://example.com"
event = Event.select().where(Event.event_type == "redirect").first()
assert event is not None
assert event.url_id_id == sample_url


def test_redirect_url_not_found(client):
Expand Down
Loading