Open
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combination of lower and upper bounds resulted in invalid ROS code
rcl_interfaces::msg::ParameterDescriptor descriptor; descriptor.description = "specifies maximum acceleration limits for x, y and z axis"; descriptor.read_only = false; descriptor.floating_point_range.resize(1); descriptor.floating_point_range.at(0).from_value = -10.0; descriptor.floating_point_range.at(0).to_value = std::numeric_limits<double>::max(); descriptor.floating_point_range.resize(2); descriptor.floating_point_range.at(1).from_value = std::numeric_limits<double>::lowest(); descriptor.floating_point_range.at(1).to_value = 10.0;where floating_point_range must not be of size greater 1.
It throws
std::length_error("Exceeded upper bound")(but bounds of this vector size, not of the declared parameter) resulting inThis PR adds build-time errors for this unsupported combination. I don't see a point in auto-merging it, users of this lib are simply encouraged to just use the correct validators.
Fixes #334