Multiple Camera support for transform_sensor#24
Merged
henrygerardmoore merged 6 commits intohumblefrom Mar 21, 2025
Merged
Conversation
rlpratt12
requested changes
Mar 18, 2025
Collaborator
rlpratt12
left a comment
There was a problem hiding this comment.
Generally looks good! The only minor change I'd suggest is making pose_covariance a vector (of vectors) to match estimation_frames so that we can pass in a different covariance for each (camera) source.
Collaborator
Collaborator
Author
Good point, I'll do that. |
Collaborator
Author
Will address this in a separate PR for that workspace |
e7224be to
12c2040
Compare
Collaborator
Author
|
Tested on HW and this works well, so merging it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds the ability to use multiple cameras and relevant documentation.
Also fixes the update rate not listening to configuration by changing the default tf timeout for the publisher to be inline with the other values of that parameter.