Skip to content

Allow the .SubjectToGround of the Trajectory type to consider bridges#2189

Open
DeathFishAtEase wants to merge 6 commits intoPhobos-developers:developfrom
DeathFishAtEase:SubjectToGround
Open

Allow the .SubjectToGround of the Trajectory type to consider bridges#2189
DeathFishAtEase wants to merge 6 commits intoPhobos-developers:developfrom
DeathFishAtEase:SubjectToGround

Conversation

@DeathFishAtEase
Copy link
Copy Markdown
Collaborator

Set Trajectory.(Straight/Bombard).SubjectToGround=false to make the corresponding types of Trajectory pass through instead of colliding when encountering a bridge.

@DeathFishAtEase DeathFishAtEase self-assigned this May 2, 2026
@DeathFishAtEase DeathFishAtEase added Needs testing ⚙️T1 T1 maintainer review is sufficient No Documentation Needed No documentation needed whatsoever labels May 2, 2026
@phoboscn-bot
Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/396/1

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@DeathFishAtEase DeathFishAtEase added Bugfix This is a bugfix that does not need documentation beyond mention in changelog ❓Phobos bug Something isn't working properly and removed No Documentation Needed No documentation needed whatsoever labels May 2, 2026
@DeathFishAtEase DeathFishAtEase marked this pull request as draft May 3, 2026 15:23
@DeathFishAtEase DeathFishAtEase marked this pull request as ready for review May 4, 2026 16:11
@DeathFishAtEase
Copy link
Copy Markdown
Collaborator Author

DeathFishAtEase commented May 5, 2026

Tested by: https://www.phoboscn.top/t/topic/396/5
image
From west to east, respectively:

  1. vanilla Arcing=true
  2. Low Speed Straight, false(Trajectory.Speed= 50 & Trajectory.Straight.SubjectToGround=false)
  3. Low Speed Straight, true (Trajectory.Speed= 50 & Trajectory.Straight.SubjectToGround=true )
  4. High Speed Straight,false(Trajectory.Speed=200 & Trajectory.Straight.SubjectToGround=false)
  5. High Speed Straight,true (Trajectory.Speed=200 & Trajectory.Straight.SubjectToGround=true )
  6. Bombard, falseTrajectory.Bombard.SubjectToGround=false
  7. Bombard, true Trajectory.Bombard.SubjectToGround=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This is a bugfix that does not need documentation beyond mention in changelog ❓Phobos bug Something isn't working properly ⚙️T1 T1 maintainer review is sufficient Tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants