Skip to content

Updateable firing anim#2029

Merged
TaranDahl merged 5 commits intoPhobos-developers:developfrom
TaranDahl:FireAnim_Tracking
Apr 18, 2026
Merged

Updateable firing anim#2029
TaranDahl merged 5 commits intoPhobos-developers:developfrom
TaranDahl:FireAnim_Tracking

Conversation

@TaranDahl
Copy link
Copy Markdown
Contributor

@TaranDahl TaranDahl commented Jan 6, 2026

Updateable firing anim

  • In vanilla, firing anims is attached to the firer, but it won't update its type and location to fit the firer's facing. This is now customizable by the following flags.

In rulesmd.ini:

[AudioVisual]
FiringAnim.Update=false   ; boolean

[SOMEWEAPON]              ; WeaponType
Anim.Update=              ; boolean, default to [AudioVisual] -> FiringAnim.Update
This effect will cause problem when used together with `[AnimType] -> Next`. `Next` modifies the Anim type over time, while this function changes it back, resulting in the Anim being unable to end.

@TaranDahl TaranDahl added ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable labels Jan 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 6, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Comment thread src/Ext/Anim/Body.cpp Outdated
Comment thread src/Utilities/GeneralUtils.h Outdated
@Otamaa
Copy link
Copy Markdown
Contributor

Otamaa commented Apr 17, 2026

LGTM

@TaranDahl TaranDahl added the Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. label Apr 17, 2026
@TaranDahl TaranDahl merged commit 6b84aa2 into Phobos-developers:develop Apr 18, 2026
6 checks passed
@TaranDahl TaranDahl deleted the FireAnim_Tracking branch April 18, 2026 17:21
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️T1 T1 maintainer review is sufficient Tested ❓Unhardcoding / Customization Make something more tweakable Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants