[BugFix] Select allied country units that have been cloaked#1389
Closed
Fly-Star-him wants to merge 3 commits intoPhobos-developers:developfrom
Closed
[BugFix] Select allied country units that have been cloaked#1389Fly-Star-him wants to merge 3 commits intoPhobos-developers:developfrom
Fly-Star-him wants to merge 3 commits intoPhobos-developers:developfrom
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
MortonPL
requested changes
Sep 23, 2024
Member
MortonPL
left a comment
There was a problem hiding this comment.
Looks good. I've run it and it looks like it also fixes a campaign bug with multiple player houses and uncontrollable stealth units.
Remember to add an entry in docs/Whats-New.md, CREDITS.md and docs/Fixed-or-Improved-Logics.md (bugfixes section). Once that's done, this PR can be merged.
Contributor
|
Partially already implemented, partially in another PR CnCNet/yrpp-spawner#20 |
MortonPL
approved these changes
Sep 23, 2024
Member
|
So uhh what are we doing with this one? |
2128644 to
799ea22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Phobos allow the player to observe friendly units that have been cloaked, but they cannot be selected unless a unit with Sensors=yes is present nearby.

So I made a short fix to select units with Sensors=yes even if they don't exist nearby.
