Emit changemaker IDs to make permissions easier

[bickelj]

When doing a lookupFromPdc command, try to emit the permissions.

[Copilot]

Pull request overview

This PR updates the charityNavigator CLI commands to surface which PDC changemakers correspond to Charity Navigator results, making it easier to act on/verify permissions by ID during lookupFromPdc, and it adjusts the updateAll upload loop to iterate over validated nonprofits.

Changes:

• Add lookupFromPdc logging of changemaker IDs derived from Charity Navigator nonprofitsPublic.edges.
• Add an early return when the Charity Navigator GraphQL response contains no data.
• Change updateAll to iterate over nonprofits (post-validation) instead of raw edges.

Comments suppressed due to low confidence (1)

src/charityNavigator.ts:392

• The async work inside nonprofits.map(async ...) (and the nested Object.entries(...).map(async ...)) is never awaited. That means the command can finish before all field posts complete, and any rejections become unhandled. Collect and await the promises (e.g., via Promise.all) so the CLI only exits after uploads finish and errors propagate.

    nonprofits.map(async (e) => {
      const changemaker = getChangemakerByEin(e.ein, changemakers);
      if (changemaker !== null) {
        Object.entries(baseFieldMap).map(async ([cnAttributeName, baseFieldShortCode]) => {
          const cnAttribute = e[cnAttributeName as keyof NonprofitPublic];

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bickelj-agent]

GLM-5.2: More than two important issues here; the two inline are the most important — unawaited nonprofits.map(async…) in updateAll (writes may not finish, rejections swallowed) and the new !data guard skipping the --output-file write on API errors. Also notable: getCharityNavigatorProfiles fetches only page 1 with a resultSize the query never uses, so the emitted IDs can be silently truncated.

[bickelj-agent]

GLM-5.2: Re-review after force-push. The unawaited-map issue is fixed (now await Promise.all), so I resolved that thread. The guard-before-output-file issue is unchanged and left open. Two new notes below: a concurrency burst in updateAll and possible truncation of the emitted changemaker IDs.

[bickelj-agent]

GLM-5.2: Promise.all here fires every nonprofit's field POSTs at once (and, via the inner Promise.all, all fields per nonprofit), which can burst the PDC API; any single rejection also aborts the batch, leaving it partially posted. Consider bounded concurrency or a sequential loop.

[bickelj]

Bro, you were the one who suggested Promise.all

[bickelj]

As imperfect as this is, and the pagination handling needs to be improved, this is still an improvement and should be merged.