fix: correct dataclass instantiation bugs in GrpFault and GrpStatus#2
Open
juelg wants to merge 1 commit intoPhilNad:mainfrom
Open
fix: correct dataclass instantiation bugs in GrpFault and GrpStatus#2juelg wants to merge 1 commit intoPhilNad:mainfrom
juelg wants to merge 1 commit intoPhilNad:mainfrom
Conversation
…Status Two bugs caused GripperFault and GripperStatus to never be properly instantiated: - `GripperStatus.fault` used a mutable dataclass instance as a default value directly, which is invalid in Python dataclasses. Fixed by adding `= False` defaults to all `GripperFault` fields and using `field(default_factory=GripperFault)` instead. - `read_status` assigned the class objects themselves (`GripperFault`, `GripperStatus`) rather than instances, causing all field assignments to mutate class-level attributes instead of instance attributes. Fixed by constructing both objects properly via their constructors.
juelg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs caused GripperFault and GripperStatus to never be properly instantiated:
GripperStatus.faultused a mutable dataclass instance as a default value directly, which is invalid in Python dataclasses. Fixed by adding= Falsedefaults to allGripperFaultfields and usingfield(default_factory=GripperFault)instead.read_statusassigned the class objects themselves (GripperFault,GripperStatus) rather than instances, causing all field assignments to mutate class-level attributes instead of instance attributes. Fixed by constructing both objects properly via their constructors.