Skip to content

chore(fmt): format ir/mod.rs and cjs_wrap/wrap.rs after #8380 - #8382

Merged
proggeramlug merged 1 commit into
mainfrom
chore/fmt-8380
Aug 18, 2026
Merged

chore(fmt): format ir/mod.rs and cjs_wrap/wrap.rs after #8380#8382
proggeramlug merged 1 commit into
mainfrom
chore/fmt-8380

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

#8380 landed from a fork branch with cargo fmt --all -- --check failing on
crates/perry-hir/src/ir/mod.rs (lines 24, 31) and
crates/perry/src/commands/compile/cjs_wrap/wrap.rs:680. I could not push to the
fork, so this applies the formatting immediately after the merge.

Attribution checked before merging: #8379 was validated in the same worktree and
is fmt-clean on its own, so both offenders belong to #8380.

Validation

  • cargo fmt --all then cargo fmt --all -- --check — exit 0
  • Only the two files above changed

Summary by CodeRabbit

  • Documentation

    • Added a changelog entry for formatting updates.
  • Refactor

    • Exposed additional module-related constants for internal tooling.
    • Reformatted generated named re-export output without changing behavior.

@proggeramlug
proggeramlug merged commit 1b61941 into main Aug 18, 2026
17 of 20 checks passed
@proggeramlug
proggeramlug deleted the chore/fmt-8380 branch August 18, 2026 19:59
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dece993d-6f45-4240-ae99-96db0e424135

📥 Commits

Reviewing files that changed from the base of the PR and between 43f5454 and cda9823.

📒 Files selected for processing (3)
  • changelog.d/8382-fmt-after-8380.md
  • crates/perry-hir/src/ir/mod.rs
  • crates/perry/src/commands/compile/cjs_wrap/wrap.rs

📝 Walkthrough

Walkthrough

The change adds two public IR constant re-exports, reformats named re-export string construction, and records the formatting update in the changelog.

Changes

Exports and formatting

Layer / File(s) Summary
IR public re-exports
crates/perry-hir/src/ir/mod.rs
Adds is_native_module and NODE_BUILTIN_MODULES to the public constants re-exports.
Formatting and changelog
crates/perry/src/commands/compile/cjs_wrap/wrap.rs, changelog.d/8382-fmt-after-8380.md
Reformats the named re-export format! expression without changing generated output. Adds a changelog note.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: jdalton

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fmt-8380

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant