fix(intl): root Segmenter handle reads via the #7341 wrappers - #8376
Conversation
#8364 added intl/segmenter.rs with ten bare get_raw_const_ptr reads in a module locked at zero. Nine are argument position and become with_const_ptr; the tenth is a real post-call reload across to_number_reject_bigint, whose ToIntegerOrInfinity can invoke user code, and becomes across_const. Ordering is unchanged and the ratchet returns to 978/978.
|
Warning Review limit reached
Next review available in: 3 minutes Limit details: You’ve used all 8 included reviews currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
#8364 landed from a fork branch with
raw_handle_debtfailing:intl/segmenter.rsis new, so it is locked at zero — new code there is expectedto use the #7341 wrappers from the start. This is a spelling change, not a
behaviour change.
The split
9 sites are argument position — the pointer is passed straight into a call
(
some_call(handle.get_raw_const_ptr::<StringHeader>())). Those takewith_const_ptr.across_constcannot express an argument-position read.1 site is a genuine post-call reload and takes
across_const:Getting that one backwards is the actual risk: using
across_constwherewith_const_ptrbelongs hoists a pointer above a collection point while thegate goes green.
Validation
python3 scripts/raw_handle_debt.py— 978/978, every module inside its ceilingcargo test --release -p perry-runtime --lib— 2590 passedscripts/run_lint_gates.sh— all 50 gates