Skip to content

chore(fmt): format optimized_libs after #8337 - #8354

Merged
proggeramlug merged 1 commit into
mainfrom
chore/fmt-8337
Aug 18, 2026
Merged

chore(fmt): format optimized_libs after #8337#8354
proggeramlug merged 1 commit into
mainfrom
chore/fmt-8337

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

#8337 landed from a fork branch whose cargo fmt --all -- --check was failing on
crates/perry/src/commands/compile/optimized_libs/no_auto.rs (lines 5, 89, 98, 134,
154) and optimized_libs/tests.rs:1299. I could not push to the fork, so this
applies the formatting immediately after the merge rather than bouncing an
otherwise-green PR over whitespace.

Attribution checked before merging #8337: clean main was fmt-clean (exit 0),
and #8337 alone on current main still failed — including no_auto.rs, which
the #8338 merge never touched. So it was the branch, not the auto-merge.

Validation

  • cargo fmt --all then cargo fmt --all -- --check — exit 0
  • Only the two files above changed

Summary by CodeRabbit

  • Chores
    • Applied code formatting updates to compilation and WebAssembly testing components.
    • Updated the changelog with formatting guidance.
    • No user-visible behavior or functionality changed.

#8337 landed from a fork branch with cargo fmt --check failing on
no_auto.rs and tests.rs. Verified this is the branch's own formatting and
not the #8338 merge: clean main was fmt-clean and #8337 alone still failed,
including no_auto.rs which #8338 never touched.
@proggeramlug
proggeramlug merged commit c1ad44c into main Aug 18, 2026
19 of 20 checks passed
@proggeramlug
proggeramlug deleted the chore/fmt-8337 branch August 18, 2026 08:36
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fb1bec3a-47df-4d4f-ac2c-5b170362d755

📥 Commits

Reviewing files that changed from the base of the PR and between 7e86f80 and 1068f85.

📒 Files selected for processing (3)
  • changelog.d/8354-fmt-after-8337.md
  • crates/perry/src/commands/compile/optimized_libs/no_auto.rs
  • crates/perry/src/commands/compile/optimized_libs/tests.rs

📝 Walkthrough

Walkthrough

The pull request applies formatting-only changes to optimized library Rust sources and adds a changelog entry. It does not alter public declarations or observable behavior.

Changes

Formatting updates

Layer / File(s) Summary
Apply Rust formatting
crates/perry/src/commands/compile/optimized_libs/no_auto.rs, crates/perry/src/commands/compile/optimized_libs/tests.rs, changelog.d/8354-fmt-after-8337.md
Reformats imports, compiler setup expressions, environment iteration, error output, and cache-key assignments. Adds a changelog note requesting formatting after change 8337.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: jdalton, thehypnoo

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fmt-8337

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant