Skip to content

test(ci): close out #8264 — no suite exclusions remain - #8335

Merged
proggeramlug merged 2 commits into
mainfrom
test/8264-close-remaining-exclusions
Aug 17, 2026
Merged

test(ci): close out #8264 — no suite exclusions remain#8335
proggeramlug merged 2 commits into
mainfrom
test/8264-close-remaining-exclusions

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

Summary

#8333 fixed the last two assertions #8264 recorded as baseline reds. Their
SUITE_EXCLUSIONS entries in scripts/ci_e2e_scope.py stayed behind, which
does not produce a red build — it produces silence: both suites keep being
skipped in per-PR CI, so the coverage the fix earned back never runs. That is
#7708's failure mode, and it is the same thing #8321 cleaned up after #8302.

SUITE_EXCLUSIONS is now empty.

#8264, start to finish

assertion group fixed by status
six native_proof_buffer_views #8302 un-excluded in #8321
shadow_slot_hygiene::canonical_str_local_keeps_shadow_binding_and_tag_dispatched_ops #8333 un-excluded here
typed_feedback::typed_feedback_guards_direct_class_field_specialization #8333 un-excluded here

Eight red assertions → zero.

Changes

  • Remove both remaining SUITE_EXCLUSIONS entries.
  • Add shadow_slot_hygiene and typed_feedback to the mapped set — --self-test
    refuses a suite that is in neither list, which is what catches the half-done
    version of this change.

Validation

Verified on this branch, at the merge of #8333:

native_proof_buffer_views  45 passed; 0 failed
shadow_slot_hygiene        13 passed; 0 failed
typed_feedback             17 passed; 0 failed
  • python3 scripts/ci_e2e_scope.py --self-test — exit 0
  • scripts/run_lint_gates.sh — all 48 lint-tier gates pass

#8264 can be closed once this lands.

Ralph Küpper added 2 commits August 18, 2026 00:43
#8333 fixed the last two baseline reds (shadow_slot_hygiene 13/13,
typed_feedback 17/17). Remove their SUITE_EXCLUSIONS entries and map both
suites; SUITE_EXCLUSIONS is now empty.
@proggeramlug
proggeramlug merged commit 6da121d into main Aug 17, 2026
@proggeramlug
proggeramlug deleted the test/8264-close-remaining-exclusions branch August 17, 2026 22:44
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The head commit changed during the review from 83e61bf to d2cf45b.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/8264-close-remaining-exclusions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant